Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[ManagementAPIs] Code generation: update services and models #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcatanese merged 5 commits into main from sdk-automation/ManagementAPIs
Aug 14, 2025

Conversation

@AdyenAutomationBot
Copy link
Collaborator

@AdyenAutomationBot AdyenAutomationBot commented Aug 8, 2025 •
edited by gcatanese
Loading

Management API

  • Add support for SepaDirectDebitInfo

OpenAPI spec files or templates have been modified on 14-08-2025 by commit.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated update to the Management APIs, refreshing the generated services and models based on recent OpenAPI specification changes. The primary impact is minor code style adjustments and formatting improvements across various PHP files, ensuring the codebase remains synchronized with the latest API definitions.

Highlights

  • Updated Code Generation: The core of this PR is an automated update to the Management APIs' services and models, reflecting recent changes in the OpenAPI specification.
  • Minor Code Style Refinements: Several files, particularly ObjectSerializer.php, received minor formatting adjustments, such as changes in foreach loop syntax and simplification of if statements for improved readability and consistency.
  • Docblock and Whitespace Adjustments: Various service files now include minor whitespace and docblock formatting changes, likely a result of the code generation process ensuring consistent code style.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be an auto-generated update, which has introduced several code style and quality issues. My review focuses on violations of the PSR-12 coding standard, such as incorrect spacing in control structures, improper formatting of if statements, and the addition of unnecessary trailing whitespace. I have also noted that several methods which do not return a value are missing the void return type hint. The provided suggestions aim to correct these issues to improve code quality and maintainability.

}
} else {
foreach($data as $property => $value) {
foreach($data as $property => $value) {
Copy link

@gemini-code-assist gemini-code-assist bot Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the PSR-12 style guide, there MUST be one space after the control structure keyword.1 

 foreach ($data as $property => $value) {

Style Guide References

Footnotes

  1. PSR-12 requires a single space after control structure keywords like foreach. ↩

Comment on lines 121 to 122
if (!is_string($timestamp)) return $timestamp;

Copy link

@gemini-code-assist gemini-code-assist bot Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the PSR-12 style guide, the body of an if statement MUST be enclosed in braces.1 This standardizes how the structures look and reduces the likelihood of introducing errors as new lines are added to the body. The original multi-line format was correct.

 if (!is_string($timestamp)) {
 return $timestamp;
 }

Style Guide References

Footnotes

  1. PSR-12 requires the body of control structures like if to be enclosed in braces. ↩

}
} else {
foreach($data as $property => $value) {
foreach($data as $property => $value) {
Copy link

@gemini-code-assist gemini-code-assist bot Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the PSR-12 style guide, there MUST be one space after the control structure keyword.1 

 foreach ($data as $property => $value) {

Style Guide References

Footnotes

  1. PSR-12 requires a single space after control structure keywords like foreach. ↩

Comment on lines 121 to 122
if (!is_string($timestamp)) return $timestamp;

Copy link

@gemini-code-assist gemini-code-assist bot Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the PSR-12 style guide, the body of an if statement MUST be enclosed in braces.1 This standardizes how the structures look and reduces the likelihood of introducing errors as new lines are added to the body. The original multi-line format was correct.

 if (!is_string($timestamp)) {
 return $timestamp;
 }

Style Guide References

Footnotes

  1. PSR-12 requires the body of control structures like if to be enclosed in braces. ↩

* Start a balance transfer
*
* @deprecated since Adyen Balance Control API v1.
* @deprecated since Adyen Balance Control API v1.
Copy link

@gemini-code-assist gemini-code-assist bot Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line has unnecessary trailing whitespace. According to PSR-12, trailing whitespace should be avoided.1 

 * @deprecated since Adyen Balance Control API v1.

Style Guide References

Footnotes

  1. PSR-12 states that trailing whitespace MUST be omitted. ↩

{
$endpoint = $this->baseURL . str_replace(['{terminalId}'], [$terminalId], "/terminals/{terminalId}/reassign");
$this->requestHttp($endpoint, strtolower('POST'), (array) $terminalReassignmentRequest->jsonSerialize(), $requestOptions);

Copy link

@gemini-code-assist gemini-code-assist bot Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is an unnecessary empty line with trailing whitespace. According to PSR-12, trailing whitespace MUST be omitted.1 Additionally, the method reassignTerminal should have a : void return type hint since it does not return a value.

Style Guide References

Footnotes

  1. PSR-12 states that trailing whitespace MUST be omitted, especially on blank lines. ↩

* @param string $webhookId
* @param array|null $requestOptions
Copy link

@gemini-code-assist gemini-code-assist bot Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line in the PHPDoc block contains unnecessary trailing whitespace. According to PSR-12, trailing whitespace MUST be omitted, especially on blank lines.1 A blank line in a docblock should be *.

 *

Style Guide References

Footnotes

  1. PSR-12 states that trailing whitespace MUST be omitted, especially on blank lines. ↩

{
$endpoint = $this->baseURL . str_replace(['{companyId}', '{webhookId}'], [$companyId, $webhookId], "/companies/{companyId}/webhooks/{webhookId}");
$this->requestHttp($endpoint, strtolower('DELETE'), null, $requestOptions);

Copy link

@gemini-code-assist gemini-code-assist bot Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is an unnecessary empty line with trailing whitespace. According to PSR-12, trailing whitespace MUST be omitted.1 Additionally, the method removeWebhook should have a : void return type hint since it does not return a value.

Style Guide References

Footnotes

  1. PSR-12 states that trailing whitespace MUST be omitted, especially on blank lines. ↩

* @param string $webhookId
* @param array|null $requestOptions
Copy link

@gemini-code-assist gemini-code-assist bot Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line in the PHPDoc block contains unnecessary trailing whitespace. According to PSR-12, trailing whitespace MUST be omitted, especially on blank lines.1 A blank line in a docblock should be *.

 *

Style Guide References

Footnotes

  1. PSR-12 states that trailing whitespace MUST be omitted, especially on blank lines. ↩

{
$endpoint = $this->baseURL . str_replace(['{merchantId}', '{webhookId}'], [$merchantId, $webhookId], "/merchants/{merchantId}/webhooks/{webhookId}");
$this->requestHttp($endpoint, strtolower('DELETE'), null, $requestOptions);

Copy link

@gemini-code-assist gemini-code-assist bot Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is an unnecessary empty line with trailing whitespace. According to PSR-12, trailing whitespace MUST be omitted.1 Additionally, the method removeWebhook should have a : void return type hint since it does not return a value.

Style Guide References

Footnotes

  1. PSR-12 states that trailing whitespace MUST be omitted, especially on blank lines. ↩

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/ManagementAPIs branch 9 times, most recently from 9176a36 to 6fd5fb7 Compare August 13, 2025 10:49
Copy link

@gcatanese gcatanese merged commit 866bed6 into main Aug 14, 2025
10 checks passed
@gcatanese gcatanese deleted the sdk-automation/ManagementAPIs branch August 14, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /