-
Notifications
You must be signed in to change notification settings - Fork 114
[ManagementAPIs] Code generation: update services and models #800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gemini-code-assist
gemini-code-assist
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @AdyenAutomationBot, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the generated PHP client for Adyen's Management APIs, reflecting recent changes in their OpenAPI specifications. The updates primarily involve minor code formatting adjustments and a slight modification to a deprecation notice, ensuring the client remains synchronized with the latest API definitions.
Highlights
- Code Formatting Refinements: Standardized foreach loop syntax and simplified if statement blocks in ObjectSerializer.php files for both Balance Control and Management models.
- Minor Deprecation Notice Adjustment: A small textual change was made to a deprecation comment in BalanceControlApi.php.
- Generated Service Method Alignment: Newlines were added at the end of requestHttp calls within various Management API service methods, likely due to updated code generation templates.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
@gemini-code-assist
gemini-code-assist
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be generated by a tool, updating services and models based on an OpenAPI specification. While the changes are mostly minor, they introduce some code style issues that violate PSR-12 standards. Additionally, several methods that do not return a value are missing the void return type hint and corresponding PHPDoc annotation, which is a good practice for code clarity and type safety. I've provided suggestions to address these points across the affected files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the PSR-12 standard, there MUST be one space after a control structure keyword. The space after foreach has been removed here.
foreach ($data as $property => $value) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change violates the PSR-12 standard, which requires control structures to use braces and have their body on a new line. This improves code readability and maintainability, and prevents potential bugs when adding more statements to the if block.
if (!is_string($timestamp)) { return $timestamp; }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the PSR-12 standard, there MUST be one space after a control structure keyword. The space after foreach has been removed here.
foreach ($data as $property => $value) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change violates the PSR-12 standard, which requires control structures to use braces and have their body on a new line. This improves code readability and maintainability, and prevents potential bugs when adding more statements to the if block.
if (!is_string($timestamp)) { return $timestamp; }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method does not return a value, so its signature should be updated with a void return type for better type safety and clarity. The PHPDoc should also be updated with @return void. Additionally, the newly added empty lines with trailing whitespace should be removed.
* @param array|null $requestOptions * @return void * @throws AdyenException */ public function deleteAllowedOrigin(string $companyId, string $apiCredentialId, string $originId, ?array $requestOptions = null): void { $endpoint = $this->baseURL . str_replace(['{companyId}', '{apiCredentialId}', '{originId}'], [$companyId, $apiCredentialId, $originId], "/companies/{companyId}/apiCredentials/{apiCredentialId}/allowedOrigins/{originId}"); $this->requestHttp($endpoint, strtolower('DELETE'), null, $requestOptions); }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method does not return a value, so its signature should be updated with a void return type for better type safety and clarity. The PHPDoc should also be updated with @return void. Additionally, the newly added empty lines with trailing whitespace should be removed.
* @param array|null $requestOptions * @return void * @throws AdyenException */ public function addApplePayDomain(string $merchantId, string $paymentMethodId, \Adyen\Model\Management\ApplePayInfo $applePayInfo, ?array $requestOptions = null): void { $endpoint = $this->baseURL . str_replace(['{merchantId}', '{paymentMethodId}'], [$merchantId, $paymentMethodId], "/merchants/{merchantId}/paymentMethodSettings/{paymentMethodId}/addApplePayDomains"); $this->requestHttp($endpoint, strtolower('POST'), (array) $applePayInfo->jsonSerialize(), $requestOptions); }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method does not return a value, so its signature should be updated with a void return type for better type safety and clarity. The PHPDoc should also be updated with @return void. Additionally, the newly added empty lines with trailing whitespace should be removed.
* @param array|null $requestOptions * @return void * @throws AdyenException */ public function deletePayoutSetting(string $merchantId, string $payoutSettingsId, ?array $requestOptions = null): void { $endpoint = $this->baseURL . str_replace(['{merchantId}', '{payoutSettingsId}'], [$merchantId, $payoutSettingsId], "/merchants/{merchantId}/payoutSettings/{payoutSettingsId}"); $this->requestHttp($endpoint, strtolower('DELETE'), null, $requestOptions); }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method does not return a value, so its signature should be updated with a void return type for better type safety and clarity. The PHPDoc should also be updated with @return void. Additionally, the newly added empty lines with trailing whitespace should be removed.
* @param array|null $requestOptions * @return void * @throws AdyenException */ public function reassignTerminal(string $terminalId, \Adyen\Model\Management\TerminalReassignmentRequest $terminalReassignmentRequest, ?array $requestOptions = null): void { $endpoint = $this->baseURL . str_replace(['{terminalId}'], [$terminalId], "/terminals/{terminalId}/reassign"); $this->requestHttp($endpoint, strtolower('POST'), (array) $terminalReassignmentRequest->jsonSerialize(), $requestOptions); }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method does not return a value, so its signature should be updated with a void return type for better type safety and clarity. The PHPDoc should also be updated with @return void. Additionally, the newly added empty lines with trailing whitespace should be removed.
* @param array|null $requestOptions * @return void * @throws AdyenException */ public function removeWebhook(string $companyId, string $webhookId, ?array $requestOptions = null): void { $endpoint = $this->baseURL . str_replace(['{companyId}', '{webhookId}'], [$companyId, $webhookId], "/companies/{companyId}/webhooks/{webhookId}"); $this->requestHttp($endpoint, strtolower('DELETE'), null, $requestOptions); }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method does not return a value, so its signature should be updated with a void return type for better type safety and clarity. The PHPDoc should also be updated with @return void. Additionally, the newly added empty lines with trailing whitespace should be removed.
* @param array|null $requestOptions * @return void * @throws AdyenException */ public function removeWebhook(string $merchantId, string $webhookId, ?array $requestOptions = null): void { $endpoint = $this->baseURL . str_replace(['{merchantId}', '{webhookId}'], [$merchantId, $webhookId], "/merchants/{merchantId}/webhooks/{webhookId}"); $this->requestHttp($endpoint, strtolower('DELETE'), null, $requestOptions); }
Quality Gate Passed Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
No changes
OpenAPI spec files or templates have been modified on 08-08-2025 by commit.