This repository was archived by the owner on Jul 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 194
Start the process to support Laravel 7 #853
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the tests except for `DatabaseProviderTest::auth_attempts_fallback_using_config_option` work and I've resolved the warnings around `@expectedException` annotations. I can't quite tell what's going on. I _think_ it's because AdLdap2 is throwing exceptions when before it only returned null or something? I wouldn't mind taking it on, but could use some direction on how you want to handle it.
rimace
commented
Mar 5, 2020
Laravel 6.0 is an LTS version. It would be nice if the LTS version would still be supported.
Yeah I agree supporting 6 would be ideal as well. orchestra/testbench v5 supports 7 but not 6. I don't know if that would hold it back from supporting both versions of Laravel?
@rimace There should be no issues supporting Laravel 5.5 and greater (up to Laravel 7.0).
Can't merge this due to requiring dev-master. I need to finish cleaning some things in the core Adldap2 package and make a new release so Laravel 7.0 is supported properly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the tests except for
DatabaseProviderTest::auth_attempts_fallback_using_config_optionwork and I've resolved the warnings around@expectedExceptionannotations. I can't quite tell what's going on. I think it's because AdLdap2 is throwing exceptions when before it only returned null or something? I wouldn't mind taking it on, but could use some direction on how you want to handle it.This would close #852 and probably mean a new version? Again, some direction would be helpful if you want some help on it. I've set the
adldap2/adldap2dependency to bedev-masterbecause I saw you did some work on supporting 7 today.Let me know!