-
-
Notifications
You must be signed in to change notification settings - Fork 52
Dev to Master: v0.6.2 #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While using this library in a non-laravel project, I hit an exception and realized this file is the only one referencing Illuminate\Database\Eloquent\Collection. These are some details on the version I'm running: ``` [ 'pretty_version' => 'v0.6.1', 'version' => '0.6.1.0', 'reference' => '973b1545c73beb34aae6a60dfac7581247e88671', ], ```
use Support\Collection instead of Eloquent\Collection
Apply fixes from StyleCI
...4 support) and replaced them with corresponding type check; added tests
Co-authored-by: JohGuentner <3506359+johguentner@users.noreply.github.com>
...laravel-notion-api into fix/remove-union-types
Replace Union Types in method parameters list with type check (temporarily)
@mechelon
mechelon
changed the title
(削除) Dev to Master: v (削除ここまで)
(追記) Dev to Master: v0.6.2 (追記ここまで)
Dec 27, 2021
johguentner
johguentner
approved these changes
Dec 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Removed union types in method parameters (temporarily for PHP 7.4 support) and replaced them with corresponding type check (Syntax error when using PHP 7.4, due to use of union type. #51 )
Changed Eloquent Collection Import to Support Collection (use Support\Collection instead of Eloquent\Collection #50 )
Added StyleCI
Added PHP 8.1 and PHP 7.4 to Workflows