Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Patch for typo, type-check, removing unused file and block-update-functionality #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johguentner merged 10 commits into main from dev
Oct 18, 2021

Conversation

@johguentner
Copy link
Member

@johguentner johguentner commented Sep 27, 2021

No description provided.

osbre reacted with thumbs up emoji
Copy link
Member Author

I can't see any issues localy and tests are running perfectly. 👌
What do you think @mechelon, should we merge this into main, and releaes with the next version, or should we create a patch-version? 🤔

Copy link
Member

I think it's not really a bug, so a release with the next version is okay :)

Copy link
Member

I would keep it in dev until next release, so we don't forget about it. (writing release notes from commit messages... 😅 )

johguentner reacted with thumbs up emoji

Copy link
Member Author

I would keep it in dev until next release, so we don't forget about it. (writing release notes from commit messages... 😅 )

Yes, same thought here. Let's do it that way 👍

- during search of databases, property-information is fetched (but no value). In the case of last_edited_time, there is suddenly an unexpected empty array, which caused an error during search
- simply added parameter to existing implementation
- allow users to set rawContent and type for flexible block creation, until all blocks are supported by laravel-notion-api
- implement setContent for text based blocks
add block-update functionality + flexible content
@johguentner johguentner changed the title (削除) Delete unused LaravelNotionApi.php (削除ここまで) (追記) Patches for typo, type-check, removing unused file and block-update-functionality (追記ここまで) Oct 18, 2021
@johguentner johguentner changed the title (削除) Patches for typo, type-check, removing unused file and block-update-functionality (削除ここまで) (追記) Patch for typo, type-check, removing unused file and block-update-functionality (追記ここまで) Oct 18, 2021
@johguentner johguentner merged commit 973b154 into main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /