Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Delete unused LaravelNotionApi.php #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johguentner merged 2 commits into 5am-code:dev from osbre:patch-1
Sep 27, 2021
Merged

Conversation

@osbre
Copy link
Contributor

@osbre osbre commented Sep 26, 2021

Looks like this class was automatically generated from a base package template. It's empty and not used anywhere.
To avoid misconceptions between Notion.php and LaravelNotionApi.php I suggest to delete it.

johguentner reacted with thumbs up emoji
@mechelon mechelon changed the base branch from main to dev September 27, 2021 08:15
Copy link
Member

@mechelon mechelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tests are running, but we should merge this into dev instead of main.

Thank you @osbre!

osbre reacted with thumbs up emoji osbre reacted with heart emoji
Copy link
Member

@johguentner johguentner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me as well 👌
I'll merge into dev and check if there's any issue with usages or similar.

Thank you @osbre for pointing this out!

osbre reacted with thumbs up emoji osbre reacted with heart emoji
@johguentner johguentner merged commit 37faf15 into 5am-code:dev Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johguentner johguentner johguentner approved these changes

@mechelon mechelon mechelon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /