-
-
Notifications
You must be signed in to change notification settings - Fork 52
Do not serialize scalar values #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
johguentner
merged 1 commit into
5am-code:fix/as-text-for-scalar-values
from
richardhj:patch-1
Apr 30, 2023
Merged
Do not serialize scalar values #129
johguentner
merged 1 commit into
5am-code:fix/as-text-for-scalar-values
from
richardhj:patch-1
Apr 30, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Summary
- Improved asText() method handling
Added a condition to better handle different content types, improving overall functionality.
Thank you @richardhj for the PR!
Yeah, this is a valid point! When I wrote the ->asText() method, I wasn't sure what to do with certain properties. For scalar values, this definitely makes sense!
Could you please write tests for the implementation. Then we will merge this within 1.1.0.
@johguentner
johguentner
changed the base branch from
dev
to
fix/as-text-for-scalar-values
April 30, 2023 13:46
@johguentner
johguentner
merged commit Apr 30, 2023
0c0233f
into
5am-code:fix/as-text-for-scalar-values
@johguentner
johguentner
removed
the
tests-required
Tests for this PR are required
label
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why all properties are becoming json_encoded, but this resulted in properties having malicious characters (i.e.,
") when usingasText().Example:
Before:
After: