-
Notifications
You must be signed in to change notification settings - Fork 102
app restructure suggestion #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Sreilys
wants to merge
1
commit into
10secondsofcode:master
from
Sreilys:suggestion-project-structure
Closed
app restructure suggestion #59
Sreilys
wants to merge
1
commit into
10secondsofcode:master
from
Sreilys:suggestion-project-structure
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worked on this Issue: #17
I had some suggestion in mind:
- file names
- improve use of router and switch plus typos
- added some comments here and there to explain what I was thinking when I changed the code :)
- I left the search functionality not complete on purpose so that someone else could take it ad a task
- would be nice to provide id field for the data, so that we could create the MentorProfile component
@Sreilys thanks for your valuable feedback for apps suggestions. I will go through and will update the feedback. I will pull your modified changes in local and will merge. Thanks a lot your help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Worked on this Issue: #17
I had some suggestion in mind: