MathAction #121 bogus <code>property change</code> comments

Topics

• FrontPage
  • IssueTracker
    • #121 bogus property change comments <-- You are here.

Some very aggressive search engines (spiders) seem to be following form action="xxxx" references in pages as well as the usual href links. As a result probes by such greedy theives can cause unexpected changes to wiki web pages. One such example recently has been the triggering of the Change button on the Issue pages. The script changeIssueProperties should be more careful not to record any change if the Change action is triggered with no actually changes.

diff -au test/Products/ZWiki/plugins/Tracker.py main/Products/ZWiki/plugins/Tracker.py
--- test/Products/ZWiki/plugins/Tracker.py 2004年11月17日 14:57:59.000000000 -0600
+++ main/Products/ZWiki/plugins/Tracker.py 2005年03月10日 22:55:09.000000000 -0600
@@ -296,10 +296,11 @@
 if status != self.status:
 comment += "Status: %s => %s \n" % (self.status,status)
 self.manage_changeProperties(status=status)
- log = log or property change
- self.comment(text=comment, subject_heading=log, REQUEST=REQUEST)
- self.setLastEditor(REQUEST)
- self.reindex_object()
+ if log or (comment != ''):
+ log = log or property change
+ self.comment(text=comment, subject_heading=log, REQUEST=REQUEST)
+ self.setLastEditor(REQUEST)
+ self.reindex_object()
 if REQUEST: REQUEST.RESPONSE.redirect(self.page_url())
 def category_index(self):

Status: open => testing

Name: '#121 bogus property change comments' => '#121 bogus property change comments' Status: testing => closed