r102289 MediaWiki - Code Review archive

Repository: MediaWiki
Revision: < r102288‎ | r102289 | r102290 >
Date: 15:36, 7 November 2011
Author: hashar
Status: ok (Comments)
Tags:
Comment:
fix badly named variable

Resource takes two S in french :D
follow up r102286
Modified paths:
  • /trunk/phase3/maintenance/generateSitemap.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/generateSitemap.php
— — @@ -347,11 +347,11 @@
348 348 * @return Resource
349 349 */
350 350 function open( $file, $flags ) {
351 (削除) - $ressource = $this->compress ? gzopen( $file, $flags ) : fopen( $file, $flags ); (削除ここまで)
352 (削除) - if( $ressource === false ) { (削除ここまで)
351 (追記) + $resource = $this->compress ? gzopen( $file, $flags ) : fopen( $file, $flags ); (追記ここまで)
352 (追記) + if( $resource === false ) { (追記ここまで)
353 353 wfDebugDieBacktrace( __METHOD__ . " error opening file $file with flags $flags. Check permissions?" );
354 354 }
355 (削除) - return $ressource; (削除ここまで)
355 (追記) + return $resource; (追記ここまで)
356 356 }
357 357
358 358 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102286 dieout when file is a boolean...hashar 14:46, 7 November 2011

Comments

#Comment by Hashar (talk | contribs)   15:36, 7 November 2011

Thanks Nike for the review!

Status & tagging log

  • 15:03, 11 November 2011 Nikerabbit (talk | contribs) changed the status of r102289 [removed: new added: ok]

AltStyle によって変換されたページ (->オリジナル) /