async.forEach iteration

Question

I want data from multiple collection and then want to merge all data. i am using async module for sequential execution. i wrote code like

var newArray = new Array();
 common.findAllById('list',{'boardId': parseInt(bId)},function(err,result){ 
 if(err) console.log(err);
 else{ 
 if(result != null){ 
 async.forEachSeries(result, function (res, callback){ 
 common.findAllById('cards',{'listId':parseInt(res.listId)},function(err,temp){
 if(err){ callback("errr"+err);}
 else{ 
 var arr = new Array();
 async.forEachSeries(temp, function(tmp,callbackFn){
 common.findAllById('checklist',{'cardId':parseInt(tmp.cardId)}, function(err,r){
 if(err){ 
 callbackFn("errr"+err);
 }
 else{
 if(r !== null){
 console.log("r:");
 tmp.checklists = r; 
 arr.push(tmp); 
 callbackFn(err);
 }
 }
 }); 
 },function(err){ 
 console.log('arr'); 
 res.cards = arr; 
 console.log(res);
 });
 newArray.push(res);
 callback(err);
 } 
 }); 
 }, function (err){
 console.log('after:');
 console.log(newArray); 
 return response.send(newArray);
 }); 
 }
 }
 });

in this code after completing inner(second) foreach loop callback function for first foreach loop sholud called but after first iteration of second foreach loop first loop's callback is called and then it continues with second foreach loop iteration. what is mistake in this code please help me. thank you in advance!

• framp: you should really considering using one of the flow control libraries (npm install seq will do), this code is hardly readable

Answer 1

You should call callback() of first forEachSeries into the the final callback of the inner forEachSeries.

},function(err){ 
 console.log('arr'); 
 res.cards = arr; 
 console.log(res);
 newArray.push(res);
 callback(err);
});

• priyanka patel: yes it is like that but there is some mistake in my code that's why it is not working properly but after doing changes in that mistake it is working.