Javascript for loop not looping

Question

I have some code that I'm working on for my work. We're trying to loop through all the links on our page and automatically add an onclick event. However, the loop doesn't appear to be "looping" at all. Could somebody please help?

var ourdomainname = "ourdomain.com";
function linkallthelinks(domain) {
 var links = document.getElementsByTagName("a");
 for (i = 0; i < links.length; i++) {
 var link = links[i];
 var href = link.getAttribute("href");
 if (href.indexOf(read_today) != -1) {
 link.setAttribute('onclick', 'alert("Okay")');
 }
 }
}
//function call
linkallthelinks(ourdomainname);​

• tereško: link.setAttribute('onclick', 'alert("Okay")'); <<< this is NOT how you attach events.
• talnicolas: Is it entering the function? do you have an error message? Have you checked the length of the list?
• gen_Eric: Is read_today a variable? Should it be 'read_today'?
• kennebec: read_today is undefined, apparently

Answer 1

Missing quotes here:

if(href.indexOf(read_today) != -1) 

Should be:

if(href.indexOf('read_today') != -1) 

Overall, this is what you should have:

var ourdomainname = "ourdomain.com";
function linkallthelinks(domain) {
 var links = document.getElementsByTagName("a");
 for (var i = 0; i < links.length; i++) {
 var link = links[i];
 var href = link.getAttribute("href");
 if (href.indexOf('read_today') != -1) {
 link.setAttribute('onclick', 'alert("Okay")');
 }
 }
}
//function call
linkallthelinks(ourdomainname);​

• gen_Eric: Don't put quotes around the onclick function.
• user1106925: This: link.setAttribute('onclick', function(){ alert("Okay") }); is incorrect. OP was doing it correctly. The 'alert("Okay");' gets automatically wrapped in a function.
• user1106925: @Rocket: It's setting an attribute, not a property, so either way it's getting the .toString() treatment.
• ccarnley7: Oh, my bad on the quotes around "read_today". Thanks for the catch! However, loop still does not appear to be looping because no events are being attached to the links...
• user1106925: @user1250254: Have you tested the .length of the a elements returned? alert(links.length);? Are you running your script before the elements have been loaded into the page?

Answer 2

try this:

if(link.href.indexOf("read_today") != -1)