Creating a function in PHP

Question

I use this often and would like to turn it into a function:

$f = fopen('../images/snotel/'. $name .'.pdf','w+');
fwrite($f, $pdf);
fclose($f);
$conv='/usr/bin/convert../images/snotel/'. $name .'.pdf ../images/snotel/'. $name .'.jpg'; 
system ($conv); 

This is what I've tried but it doesn't seem to work:

function pdf2jpg($name)
{
 $f = fopen('../images/snotel/'. $name .'.pdf','w+');
 fwrite($f, $pdf);
 fclose($f);
 $conv='/usr/bin/convert../images/snotel/'. $name .'.pdf ../images/snotel/'. $name .'.jpg'; 
 system ($conv);
}
...
pdf2jpg('wsr');

• Mob: Expatiate on what happens when you call the method.
• mario: Is that your actual code? Lack of spaces after the command? Did you look into the error.log yet?
• Chris Kempen: There doesn't seem to be a parameter for the $pdf variable anywhere in your function...could you elaborate?

Answer 1

As it is, your function tries to write the file with no data in the $pdf variable, because you did not pass it in.

You need to do one of two things:

This version takes the PDF data as an argument and creates the file in the function:

function pdf2jpg ($pdf, $name) {
 $f = fopen('../images/snotel/'.$name.'.pdf','w');
 fwrite($f,$pdf);
 fclose($f);
 $conv = '/usr/bin/convert ../images/snotel/'.$name.'.pdf ../images/snotel/'.$name.'.jpg'; 
 //run 
 system($conv);
}
// Usage
pdf2jpg($pdf, 'wsr');

This version just takes the name, assuming that the file already exists:

function pdf2jpg ($name) {
 $conv = '/usr/bin/convert ../images/snotel/'.$name.'.pdf ../images/snotel/'.$name.'.jpg'; 
 //run 
 system ($conv);
}
// Usage
$name = 'wsr';
$f = fopen('../images/snotel/'.$name.'.pdf','w');
fwrite($f,$pdf);
fclose($f);
pdf2jpg($name);

• grantiago: Tnx all. I was (foolishly) expecting an email notification and just forgot about this question. I had figured it out on my own in the meantime.