Style PHP variable in JavaScript

Question

<?php 
...
$name = trim($_POST["username"]);
...
echo '<script type="text/javascript">document.getElementById("message").innerHTML=
"<span style='color:red;'>'.$name.'</span> <br>login now";</script>';
?>

Why the style isn't working? When I erase the style and span the code is working fine.

• HPierce: What does "isn't working" mean? White screen of death?
• Comrade57: "isn't working" meaning it prints(echo) nothing, so my guess is that this code is not valid...
• HPierce: See: How do I get PHP errors to display?

Answer 1

Your need to escape the quotes around 'color:red;', that's invalid:

echo '<script type="text/javascript">document.getElementById("message").innerHTML=
"<span style=\'color:red;\'>'.$name.'</span> <br>login now";</script>'

• Comrade57: Thank you so much!
• Jacob G: No problem, glad I could help :)

Answer 2

Your need to escape style=\'color:red;\'

<?php
echo '<div id="message"></div>
 <script type="text/javascript">document.getElementById("message").innerHTML=
 "<span style=\'color:red;\'>'.$name.'</span> <br>login now";</script>';
?>

• Jacob G: How's this any different than my answer?
• Mohammad: oh , You sent this answer .
• Jacob G: yeah, I guess we both had the same idea :)