Javascript function inside ahref not working in php echo [closed]

Question

Closed. This question needs debugging details. It is not currently accepting answers.

---

Edit the question to include desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem. This will help others answer the question.

Closed 10 years ago.

Improve this question

I have a series of images/links that is calling a javascript function when the image is clicked. The code below works fine in regular html, but when I try to use this inside of a php echo it doesn't work.

echo "<a href='javascript:nfllogin('nflshow');' class='black' style='font-size:12px;'><img src='images/nfl-button-index.jpg' width='177' height='145' alt=''/></a> ";

Everything appears fine but when I click the image/link it doesn't pull up the div area I am expecting to see. How can I make this work?

• James: Single quotes inside single quotes won't work. Use \"" for one of the sets eg \""nflshow\""
• Paul Roub: Possible duplicate of How to use javascript inside a PHP echo function?
• Funk Forty Niner: Why did you post a possible duplicate and post an answer also? bit of a monopoly, wouldn't you agree?
• user3765759: @Fred-ii- I am sorry I usually always try and accept an answer when it works. I will try and look back to see if there was any answers from you I forgot to accept
• user3765759: @PaulRoub I read the possible duplicate before I posted but couldn't figure it out for what I was doing. I am a beginner so I just needed the example you gave me below. Thanks!

Answer 1

You'll need to escape some of the quotes to avoid nested quotes of the same type.

echo "<a href='javascript:nfllogin(\"nflshow\");' class='black' style='font-size:12px;'><img src='images/nfl-button-index.jpg' width='177' height='145' alt=''/></a> ";

Will actually output:

<a href='javascript:nfllogin("nflshow");' class='black' style='font-size:12px;'><img src='images/nfl-button-index.jpg' width='177' height='145' alt=''/></a> 

Which should work better for you.

• user3765759: This worked perfect thank you

Answer 2

echo '<a href="javascript:nfllogin(\"nflshow\");" class="black" style="font-size:12px;"><img src="images/nfl-button-index.jpg" width="177" height="145" alt=""/></a>';

a good practice in echoing html in php is use single quote to echo and double quotes thereafter. This save the stress of escaping string. Try the above pls.

if it doesnt respond change this: javascript:nfllogin("nflshow");

Answer 3

The first thing that hits my eyes is that there's a problem with single and double quotes.

echo '<a href="javascript:nfllogin(\'nflshow\');" ';
echo "class='black' style='font-size:12px;'><img src='images/nfl-button-index.jpg' width='177' height='145' alt=''/></a> ";

Since the JavaScript contains a single quote, you have to put the href into double quotes. I split the echo in two to avoid to escape quotes with backslashes.

To echo such big chunks of html, the heredoc syntax comes in handy too. This would look like:

echo <<<EOT
<a href="javascript:nfllogin(\'nflshow\');" class="black" style="font-size:12px;">
 <img src="images/nfl-button-index.jpg" width="177" height="145" alt=""/>
</a>
EOT;

There are two advantages:

• There's no need to escape quotes
• As a consequence, you can indent your HTML code and use double quotes for the attributes. It's just a matter of clean code to quote all HTML code consistently with double quotes.

• Lorenz Meyer: Sorry, I was too fast. I corrected.