Javascript while loop conditions

Question

The following javascript fragment goes into an infinite loop. Why is that?

 var playerChoice=prompt("Choose paper or rock or scissors"); 
 while (playerChoice !=="paper" || playerChoice !=="rock" || playerChoice !== "scissors"){ 
 playerChoice=prompt("Choose paper or rock or scissors"); 
 } 

• Paul Fitzgerald: it should just be playerChoice != "paper"
• lakshman: why are you not usin if condition??
• Minhajraz: tried it with != still not working!!!
• James Thorpe: @Minhajraz != vs !== shouldn't make a difference here. Have you tried switching to using && instead of || as per the various answers?

Answer 1

Because when a new choice is made, it will always match at least two of the conditions, and since you've used the OR (||) operator, will continue with the loop. You need to use the AND (&&) operator instead:

var playerChoice=prompt("Choose paper or rock or scissors");
while (playerChoice !=="paper" && playerChoice !=="rock" && playerChoice !== "scissors"){
 playerChoice=prompt("Choose paper or rock or scissors"); 
}

Now when a valid choice is made, two of the 3 inner conditions are still met, but because the last one isn't, the whole condition will evaluate to false and the loop will not execute.

• Minhajraz: Thanks for explanations @james Thorpe.

Answer 2

You need to use &&. You need to quit the loop if the choice is either one of the valid choices

while (playerChoice != "paper" && playerChoice != "rock" && playerChoice != "scissors") {
 playerChoice = prompt("Choose paper or rock or scissors");
}

Demo: Fiddle

In your case assume, playerChoice is paper but when evaluating your condition playerChoice !=="rock" is true and since you have used || if any of the condition is true the loop will get executed

• Paul Fitzgerald: The issue is with the !=, is it not?
• Minhajraz: I thought && will only return 'true' if all the values are true. I want it to return true if either case is true
• James Thorpe: @PaulFitzgerald See the Strict Inequality operator vs the Inequality operator. !== is perfectly valid.
• T.J. Crowder: @PaulFitzgerald: No, it isn't.
• Minhajraz: Any one with any other idea?? I am stack here!

Answer 3

You're using OR where you should be using AND, whether Rock, Paper or Scissors is entered two of your conditions will evaluate as TRUE so you'll go around the loop again, and again, and again.....