Insert php in javascript inside echo

Question

I have my Javascript inside echo, but i want it to have a php also inside. I dont know if it is possible, just want to know the right way. cheers.

<?php 
 if($_GET["main"]=="add-doc"){
 echo "<script> 
 var r=confirm(\"Press a button\");
 if (r==true)
 {
 <? require_once(\"doc_add.php\"); ?> <--- PHP here
 }
 else
 {
 x=\"You pressed Cancel!\";
 }
 </script>";
 } 
?>

• Petros Mastrantonas: php can output javascript without problem. just not sure what you want to accomplish
• PleaseStand: possible duplicate of Reference: Why does the PHP code in my Javascript not work?
• Ikong: @PetrosMastrantonas - i want to confirm the user before going to certain page, if it answer yes i want to require the page. any other way or suggestions i could try?

Answer 1

Technically is there no difference including PHP in HTML or in CSS or in JavaScript. HTML is static. CSS and JavaScript are client side dynamic languages to complement HTML. They add to HTML what PHP or any other server side language can not do server side.

That is why using PHP in JavaScript is considered an anti-pattern. CSS and JavaScript should perform actions that the server side is not able to control. All the information for those actions should therefor be client side. Maintenance is more difficult when the code of JavaScript can be found within a PHP page. Create an .js file instead, make a function call returning what is in doc_add.php and go for it.

• Ikong: I think i understand what you are trying to say...I'll just have to get used to it then..so much to learn
• Loek Bergman: We all have, that is why the community of stackoverflow exists in the first place. :-) Reading your comment that it is a confirmation before going to that certain page I can tell you that this is pure client side JavaScript. You can for instance make use of innerHTML or unhide a div based on the action.
• Ikong: yup i had just made an adjustment. i did my code something like this <a href='index.php?main=add-doc' class='footer-img' onclick=\"return confirm('Do you really want to go?');\">. Its not inside my PHP anymore.

Answer 2

if($_GET["main"]=="add-doc"){
 echo "<script>
 var r=confirm(\"Press a button\");
 if (r==true)
 {
 " . require_once('doc_add.php') . " 
 }
 else
 {
 x=\"You pressed Cancel!\";
 }
 </script>";
}

Answer 3

First you need to understand that PHP is a server-side script, and javascript is a client-side script. This means that once the PHP script finishes rendering the HTML file, it cannot do any more actions.

What you can do, is dynamically render the javascript content before javascript runs.

in your case:

<?php 
 if($_GET["main"]=="add-doc"){ ?>
 <script> 
 var r=confirm("Press a button");
 if (r==true)
 {
 <? require_once(\"doc_add.php\"); ?>
 }
 else
 {
 x="You pressed Cancel!";
 }
 </script>
 <?php
 } 
?>

• Ikong: actually i did this before posting this question but my problem is the output. insted the confirm it just echo '} else { x=\"You pressed Cancel!\"; }'

Answer 4

Just echo the additional part.

By the way, you could use ' for echo so that you don't have to escape the " in javascript. (Although " and ' quotes in PHP are slightly different, it works functionally in this case.) Or you could use ' inside the javascript.

<?php 
 if($_GET["main"]=="add-doc"){
 echo '<script> 
 var r=confirm("Press a button");
 if (r==true)
 {';
 require_once("doc_add.php");
 // Make sure the file returns valid javascript
 echo '}
 else
 {
 x="You pressed Cancel!";
 }
 </script>';
 }

• Ikong: actually i did this before posting this question but my problem is the output. insted the confirm it just echo '} else { x=\"You pressed Cancel!\"; }'. Same as the other solution
• user2416945: @user1999194 What is in the doc_add.php?
• Ikong: i want to confirm the user before going to certain page (here add_doc.php), if it answer yes i want to require the page, if no then nothing happens. any other way or suggestions i could try?
• user2416945: @user1999194 Post your doc_add.php in the original question