Dynamic Variable Names with JavaScript - Two arrays?

Question

I'm trying to generate markers for every user in my $.each loop in such a way that I can select each marker using the corresponding userId of a given user.

$.each($.parseJSON(window.usersArray), function (i, user) {
 window.userMarkers[user['id']] = L.marker(98.76, 12.34).addTo(map);
 console.log(window.userMarkers[user['id']]);
});

EDIT

I get the error: Cannot set property '3' of undefined, where 3 is the user's ID.

• Shanimal: user['id'] ? should be user[i]
• km6zla: are you getting a console error? What is L.marker(98.76, 12.34).addTo(map); and why does it have nothing to do with user?
• acdcjunior: You do know there's a missing ); in the end, right?
• acdcjunior: Still wrong. The last line should be });, not )}.
• tylerl: ahhh sorry - no, the user['id'] comes from my database and is an actual user's unique ID - in other words it's totally independent of i here. And L.marker(98.76, 12.34).addTo(map); is just the code that adds the marker to the map in Leaflet - I wasn't sure if I should remove it or not. And yes, you're right, I forgot the );, added it in. Validating from now on!

Answer 1

You need to create the object (or array depending on your needs) before you can add anything to it.

window.userMarkers = {};
$.each($.parseJSON(window.usersArray), function (i, user) {
 window.userMarkers[user['id']] = L.marker(98.76, 12.34).addTo(map);
 console.log(window.userMarkers[user['id']]);
});

Answer 2

Solution: Define the array before setting properties to it! Example:

window.userMarkers = new Array();

• James Montagne: Don't use new Array() use []. Also, if the keys can be non-numeric or are very sparse, you probably want to use an object instead as in my answer using {} to initialize it.