PHP Undefined Index [duplicate]

Question

This question already has answers here:

"Notice: Undefined variable", "Notice: Undefined index", "Warning: Undefined array key", and "Notice: Undefined offset" using PHP (29 answers)

Closed 6 years ago.

I have this code and it's giving me an undefined error if country is not a variable in the URL. I've never had this problem before so it's obviously something to do with server settings but I'd rather not change those because this is probably done for security purposes. I've searched Google and can't find the workaround, although I'm sure it's blindingly obvious!

$country = $_GET['country'];
 if(!$country){
 $incoming = $outgoing = $sms = $free = "---";
 } else {
 get_rates($country);
 }

Answer 1

you should use the following approach:

if (!isset($_GET['country'])) {
 $incoming = $outgoing = $sms = $free = "---";
} else {
 get_rates($_GET['country']);
}

• Thomas Owens: Actually, I think you want if(!isset(...)) {
• Shoan: You are missing a closing ']' bracket in the if statement
• Peter Krauss: $country = @$_GET['country']; // the OLD PHP way to avoid notices

Answer 2

isset allows you to check if the variable exists (if not we give it the value false).

$country = isset($_GET['country'])? $_GET['country'] : false;

Answer 3

"Undefined index" means that element doesn't exist in the array. Your server is probably set to report these errors, while your system so far wasn't. Check if the element exists before accessing it.

$country = null;
if (!empty($_GET['country']) {
 $country = $_GET['country'];
}

Answer 4

You should probably check to see if $_GET['country'] is set. I would wrap the entire code block you posted in an if statement that checks if the country field is set, using the isset function.

Answer 5

Just change:

$country = $_GET['country'];

To this:

$country = @$_GET['country'];

'@' is an operator which will remove errors output.

• SilentGhost: that's the worst piece of advice one could give
• FWH: In this case it's ok because there's a check just after.
• markus: using @ error supressor is quite a stinky code smell, read about code smells on SO
• Peter Krauss: @ IS OK for some contexts, in conscious use. It is NOT A DEPRECATED operator. The main typical use is with $_POST and $_GET, like '<input name="x" value="<?= $_POST['x']?>"/>'. The FWH suggestion is good: initialize $contry with '' or with a value, there are NO SIDE EFFECT!