Concatenation php string to javascript string

Question

I have some question about concatenation php string to javascript string ...

for example:

php variable

$man = "Jamse";

and have javascript function

<script>
 if (document.getElementById("fname").value == "") {
 q = false;
 msg = <?php echo 'Please fill first name'.$formErrors['fname'].'\n' ?>;
 }
</script>

i want to do something like this can anyone help me ?

Answer 1

alert('my name is: <?php echo $man; ?>' );

• VostanAzatyan: what can i do if i need to exactly concat it ?
• ElGavilan: When your page is rendeded, <?php echo $man; ?> will be replaced with whatever is in $man; in this case the rendered output will be alert('my name is: Jamse' );
• ElGavilan: @MikeChristensen That is a good point. If $man is populated via user input (via form, etc.) you will want to validate your input.
• ElGavilan: The question as you have it now should work, assuming $formErrors is declared and has valid values.
• ElGavilan: Just an aside, you may want to put in a space :) <?php echo 'Please fill first name '.$formErrors['fname'].'\n' ?>;

Answer 2

alert('my name is: <?= $man; ?>');

Since PHP will insert $man on the server side, it's not a separate string that must be combined by JS. All the browser will see is

alert('my name is: Jamse');

Answer 3

Why not write it all in php?

<?php
$man = "Jamse";
echo "<script>
function alertMyName() {
 alert('my name is:" . $man . "');
}
</script>";
?>

• user3147515: @ElGavilan can you elaborate?
• ElGavilan: It is better to leave the static parts of the HTML and javascript code in place and only use PHP to render the dynamic parts. Echoing the entire HTML is generally considered bad form as it makes your code harder to maintain and more prone to errors.

Answer 4

The other answers are true, I just forgot to write quotes and javascript did not understand it was a String and gave me an error. The correct code:

 if (document.getElementById("fname").value == "") {
 q = false;
 msg = "<?php echo 'Please fill first name'.$formErrors['fname'].'\n'; ?>";
 }

• David Makogon: Are you answering your own question? Or posting further info? It's hard to understand the sentence above the code (plus the sentence is part of the code block). If this is indeed an answer, please edit it to be readable. If it's additional info for your question, edit your question.
• dcastro: @DavidMakogon I think he's just agreeing with the other answers, which told him to use quotes.