0

I'm tring to write a query but I obtain a syntax error. I know that this error is in the query's syntax. This is the query

ResultSet set=statement.executeQuery("Select * from Ombrellone where PosizioneX='"+c.getX()+"',PosizioneY='"+c.getY()+"'" );

Anyone can help me?

Suresh Atta
122k38 gold badges207 silver badges315 bronze badges
asked Oct 15, 2014 at 15:00
2
  • 1
    Unrelated: you are wide open for SQL Injection. You should use a PreparedStatement Commented Oct 15, 2014 at 15:04
  • @a_horse_with_no_name Though it is not related, it's a bigger problem than the current problem :) Commented Oct 15, 2014 at 15:09

2 Answers 2

5

If you want to have multiple conditions on select, you must use AND, not comma.

ResultSet set=statement.executeQuery("Select * from Ombrellone where PosizioneX='"+c.getX()+"' and PosizioneY='"+c.getY()+"'" );

Side note : Avoid using String concatination with query parameters. They causes SQL injections and try using PreparedStatement.

answered Oct 15, 2014 at 15:03
Sign up to request clarification or add additional context in comments.

Comments

1

Though the problem in your case was basically because you used comma on your SQL query which is wrong you can use AND or OR for condition fulfillment when using WHERE clause but also I would suggest you to use PreparedStatement over Statement.

String query = "Select * from Ombrellone where PosizioneX = ? and PosizioneY = ?"
PreparedStatement statement = conn.prepareStatement(query);
statement.setString(1,c.getX());
statement.setString(2,c.getY());
ResultSet resultSet = statement.executeQuery();

Refer difference between statement and preparedstatement

answered Oct 15, 2014 at 15:12

2 Comments

PreparedStatement is definitely the better choice here, however, strictly speaking, is secondary to the problem. The problem was the use of comma instead of and.
@Brandon agreed but the solution should always be perfect

Your Answer

Draft saved
Draft discarded

Sign up or log in

Sign up using Google
Sign up using Email and Password

Post as a guest

Required, but never shown

Post as a guest

Required, but never shown

By clicking "Post Your Answer", you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.