matplotlib-devel Mailing List for matplotlib

John Hunter <jd...@gm...> writes:
> * I commented out the random number appending, because I do not see
> the use case, but we can re-add it when you enlighten me :-)
I did that in case someone wanted to retrieve files from several
different locations -- my version of the cache handler was not tied to
any particular base URL. Since all cached files were in one flat
directory, there was the danger of filename collisions. 
> * I added support for nested subdirs, so you can now do, as in
> examples/misc/sample_data_test.py::
>
> datafile = 'testdir/subdir/testsub.csv'
> fh = cbook.get_sample_data(datafile)
I think mirroring a directory structure is somewhat more complicated
than caching a set of arbitrary URLs in a flat cache directory. For
example, I think the remove_stale_files method will need to be changed
to walk all subdirectories, and handling cases such as having a
subdirectory named foo that is replaced by a file named foo could be
complicated.
One thing that's still missing is off-line usage: if the user does not
have net connectivity at the moment but does have the file in the cache,
it should not cause an error.
Perhaps the base URL should be 
http://matplotlib.svn.sourceforge.net/svnroot/matplotlib/trunk/sample_data/
instead of
http://matplotlib.svn.sourceforge.net/viewvc/matplotlib/trunk/sample_data/
to avoid dependency on the viewvc service of SourceForge.
-- 
Jouni K. Seppänen
http://www.iki.fi/jks

Hi John,
I've seen them both and will apply try to fix them. I've also
submitted a support request to sourceforge to see if they can fix the
bug assignment issue. It's ok if you assign mplot3d bugs to me then.
Cheers,
Reinier
On Sat, Aug 8, 2009 at 2:33 PM, John Hunter<jd...@gm...> wrote:
> On Fri, Aug 7, 2009 at 8:27 AM, Reinier Heeres<re...@he...> wrote:
>> Hi,
>>
>> This looks great! I'd be happy to try and work on this for mplot3d as well.
>>
>> Ryan: as for your patch, I'll look at it over the weekend or next week
>> and see if I can apply it to trunk.
>
> Hey Reinier, while you are looking these over, I just wanted to make
> sure you saw these two mplo3d bugs posted on the tracker
>
> https://sourceforge.net/tracker/?func=detail&aid=2830483&group_id=80706&atid=560720
> https://sourceforge.net/tracker/?func=detail&aid=2834105&group_id=80706&atid=560720
>
> Normally, I can assign bugs on the tracker to a developer, but for
> some reason even though you are permissioned in the
> "Members" area for the tracker, your sf login isn't showing up in the
> drop down of developers on the bugs page. If you are unable o manage
> the bug, eg to change the resolution or status, let me know after you
> have taken a look at these and I can close or update them as
> necessary.
>
> JDH
>
-- 
Reinier Heeres
Tel: +31 6 10852639

Here are a few patches that we in Sage have been applying to our version 
of matplotlib. I'm wondering if some or all of these might be 
incorporated into matplotlib, or if not, if you could comment on these 
patches. I've updated the following diffs to be against 0.99.0. I've 
separated the patches with a bunch of dashes.
lib/matplotlib/cbook.py: The background information for this patch is 
found at http://trac.sagemath.org/sage_trac/ticket/1967 and 
http://groups.google.com/group/sage-support/browse_thread/thread/edcf2740f7276e6a?hl=en#78ee7d78a0a99f12
--- src/lib/matplotlib/cbook.py 2009年08月01日 12:15:07.000000000 -0700
+++ patches/cbook.py 2009年08月08日 23:15:21.000000000 -0700
@@ -14,7 +14,10 @@
 
 
 # on some systems, locale.getpreferredencoding returns None, which can 
break unicode
-preferredencoding = locale.getpreferredencoding()
+try:
+ preferredencoding = locale.getpreferredencoding()
+except:
+ preferredencoding = None
 
 def unicode_safe(s):
 if preferredencoding is None: return unicode(s)
-----------------------------------------------------------------------------------------------------------------------------------------------
lib/matplotlib/patches.py: The comment attached to this patch was '* 
Add a patch for patches.py, which ignores the errors generated when 
trying to draw arrows that are "too short".' I actually made this 
patch, so if it isn't obvious what the patch is doing and why it was 
causing an error before, I can try to remember and construct an example.
--- src/lib/matplotlib/patches.py 2009年08月01日 12:15:07.000000000 -0700
+++ patches/patches.py 2009年08月08日 23:25:09.000000000 -0700
@@ -2326,15 +2326,21 @@
 x, y = path.vertices[0]
 insideA = inside_circle(x, y, shrinkA)
 
- left, right = split_path_inout(path, insideA)
- path = right
+ try:
+ left, right = split_path_inout(path, insideA)
+ path = right
+ except ValueError:
+ pass
 
 if shrinkB:
 x, y = path.vertices[-1]
 insideB = inside_circle(x, y, shrinkB)
 
- left, right = split_path_inout(path, insideB)
- path = left
+ try:
+ left, right = split_path_inout(path, insideB)
+ path = left
+ except ValueError:
+ pass
 
 return path
 
---------------------------------------------------------------------------------------------------------------------------------------
ttconv/pprdrv_tt2.cpp: This patch is *only* applied when `uname` = 
"SunOS". The comment is: Copy patched version of pprdrv_tt2.cpp for 
Solaris 10 that builds with gcc 4.3.2.
--- src/ttconv/pprdrv_tt2.cpp 2009年08月01日 12:15:15.000000000 -0700
+++ patches/pprdrv_tt2.cpp 2009年08月08日 23:33:24.000000000 -0700
@@ -104,7 +104,8 @@
 { /* have a log of points. */
 if(stack_depth == 0)
 {
- stream.put_char('{');
+ // Note the below is a hack to make it compile on Solaris 
10 with gcc 4.3.2
+ stream.puts("{");
 stack_depth=1;
 }
 
--------------------------------------------------------------------------------------------------------------------------------------------
setupext.py: The background for this patch is here: 
http://trac.sagemath.org/sage_trac/ticket/4176
--- src/setupext.py 2009年08月01日 12:15:24.000000000 -0700
+++ patches/setupext.py 2009年08月08日 23:43:29.000000000 -0700
@@ -1034,6 +1038,7 @@
 # of distros.
 
 # Query Tcl/Tk system for library paths and version string
+ tk_ver = ''
 try:
 tcl_lib_dir, tk_lib_dir, tk_ver = query_tcltk()
 except:
Thanks!
Jason