matplotlib-devel Mailing List for matplotlib

Looks like that fixed it. Thanks!
Jim
________________________________
From: Benjamin Root <ben...@ou...>
To: Jae-Joon Lee <lee...@gm...>
Cc: James Kitchen <ji...@ya...>; mat...@li...
Sent: Thu, March 3, 2011 11:40:32 AM
Subject: Re: [matplotlib-devel] Bug in Draggable Legend
On Thu, Mar 3, 2011 at 10:30 AM, Jae-Joon Lee <lee...@gm...> wrote:
I just committed a change that I believe that fixes this problem.
>
>https://github.com/matplotlib/matplotlib/commit/be420a34031c9c50813bc5be5f01a3cfb49639a1
>
>
>Regards,
>
>-JJ
>
>
>
Confirmed that it fixes the problem for me on the GTKAgg backend as well.
Ben Root
 

On Thu, Mar 3, 2011 at 10:30 AM, Jae-Joon Lee <lee...@gm...> wrote:
> I just committed a change that I believe that fixes this problem.
>
>
> https://github.com/matplotlib/matplotlib/commit/be420a34031c9c50813bc5be5f01a3cfb49639a1
>
> Regards,
>
> -JJ
>
>
Confirmed that it fixes the problem for me on the GTKAgg backend as well.
Ben Root

I just committed a change that I believe that fixes this problem.
https://github.com/matplotlib/matplotlib/commit/be420a34031c9c50813bc5be5f01a3cfb49639a1
Regards,
-JJ
On Fri, Mar 4, 2011 at 12:58 AM, James Kitchen <ji...@ya...> wrote:
> Hi all,
>
> I found a small bug in the Draggable Legend feature when you single-click on a
> legend, but don't drag it. It raises a TypeError.
>
> Here's code to reproduce. Try dragging the legend, then single-click the
> legend.
>
> #!/usr/bin/env python
> import matplotlib as mpl
> import pylab
>
> fig = pylab.figure()
> ax = fig.add_subplot(111)
> ax.plot(range(10), range(10), c='r', marker='^', picker=5, label='Ramp')
> legn = ax.legend()
> legn.draggable()
> pylab.show()
>
>
> Here's the stacktrace when I single-click:
>
> Exception in Tkinter callback
> Traceback (most recent call last):
> File "C:\Python26\lib\lib-tk\Tkinter.py", line 1410, in __call__
>  return self.func(*args)
> File "C:\Python26\lib\site-packages\matplotlib\backends\backend_tkagg.py",
> line 312, in button_release_event
>  FigureCanvasBase.button_release_event(self, x, y, num, guiEvent=event)
> File "C:\Python26\lib\site-packages\matplotlib\backend_bases.py", line 1561,
> in button_release_event
>  self.callbacks.process(s, event)
> File "C:\Python26\lib\site-packages\matplotlib\cbook.py", line 262, in process
>  proxy(*args, **kwargs)
> File "C:\Python26\lib\site-packages\matplotlib\cbook.py", line 188, in
> __call__
>  return mtd(*args, **kwargs)
> File "C:\Python26\lib\site-packages\matplotlib\offsetbox.py", line 1466, in
> on_release
>  self.finalize_offset()
> File "C:\Python26\lib\site-packages\matplotlib\legend.py", line 51, in
> finalize_offset
>  loc_in_canvas = self.get_loc_in_canvas()
> File "C:\Python26\lib\site-packages\matplotlib\offsetbox.py", line 1512, in
> get_loc_in_canvas
>  ox, oy = offsetbox._offset
> TypeError: 'instancemethod' object is not iterable
>
> Jim
>
>
>
>
>
> ------------------------------------------------------------------------------
> Free Software Download: Index, Search & Analyze Logs and other IT data in
> Real-Time with Splunk. Collect, index and harness all the fast moving IT data
> generated by your applications, servers and devices whether physical, virtual
> or in the cloud. Deliver compliance at lower cost and gain new business
> insights. http://p.sf.net/sfu/splunk-dev2dev
> _______________________________________________
> Matplotlib-devel mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
>

Hi all,
I found a small bug in the Draggable Legend feature when you single-click on a 
legend, but don't drag it. It raises a TypeError.
Here's code to reproduce. Try dragging the legend, then single-click the 
legend.
#!/usr/bin/env python
import matplotlib as mpl
import pylab
fig = pylab.figure()
ax = fig.add_subplot(111)
ax.plot(range(10), range(10), c='r', marker='^', picker=5, label='Ramp')
legn = ax.legend()
legn.draggable()
pylab.show()
Here's the stacktrace when I single-click:
Exception in Tkinter callback
Traceback (most recent call last):
 File "C:\Python26\lib\lib-tk\Tkinter.py", line 1410, in __call__
 return self.func(*args)
 File "C:\Python26\lib\site-packages\matplotlib\backends\backend_tkagg.py", 
line 312, in button_release_event
 FigureCanvasBase.button_release_event(self, x, y, num, guiEvent=event)
 File "C:\Python26\lib\site-packages\matplotlib\backend_bases.py", line 1561, 
in button_release_event
 self.callbacks.process(s, event)
 File "C:\Python26\lib\site-packages\matplotlib\cbook.py", line 262, in process
 proxy(*args, **kwargs)
 File "C:\Python26\lib\site-packages\matplotlib\cbook.py", line 188, in 
__call__
 return mtd(*args, **kwargs)
 File "C:\Python26\lib\site-packages\matplotlib\offsetbox.py", line 1466, in 
on_release
 self.finalize_offset()
 File "C:\Python26\lib\site-packages\matplotlib\legend.py", line 51, in 
finalize_offset
 loc_in_canvas = self.get_loc_in_canvas()
 File "C:\Python26\lib\site-packages\matplotlib\offsetbox.py", line 1512, in 
get_loc_in_canvas
 ox, oy = offsetbox._offset
TypeError: 'instancemethod' object is not iterable
Jim
 

On Thu, Mar 3, 2011 at 3:15 AM, Martin Teichmann <lkb...@gm...>wrote:
> Hi Benjamin, Hi List,
>
> sorry for the backwards patch, here the forward one:
>
> ------------------------------------------------------------------------
> --- backend_qt4_orig.py 2011年03月02日 16:16:38.257797767 +0100
> +++ backend_qt4.py 2011年03月02日 16:17:19.526831397 +0100
> @@ -395,8 +395,9 @@
> filters.append(filter)
> filters = ';;'.join(filters)
>
> - fname = QtGui.QFileDialog.getSaveFileName(
> - self, "Choose a filename to save to", start, filters,
> selectedFilter)
> + fname, _ = QtGui.QFileDialog.getSaveFileNameAndFilter(
> + self, "Choose a filename to save to", start, filters,
> + selectedFilter)
> if fname:
> try:
> self.canvas.print_figure( unicode(fname) )
>
> ----------------------------------------------------------------------------
>
> It is done against a rather old version of matplotlib (the 0.99.3, the
> newest in kubuntu...) but the code hasn't changed since then,
> acording to github, so only the line numbers are wrong.
>
> The second patch I sent is now obsolete, as you hinted to the
> patch on github. I had followed the link on the matplotlib
> web site (http://matplotlib.sourceforge.net/) which links still to
> some subversion repository once you click onto "source code"
> Could please someone update that link to github? Or is there
> a new matplotlib website as well (google didn't find one).
>
> Greetings
>
> Martin
>
> --
> Max-Born-Institut
> Max-Born-Straße 2a
> 12489 Berlin
> +49 30 6392 1234
>
Martin,
Just for completeness, I wanted to include a link to some sort of reference
indicating a need to change the function. I can not find any documentation
that says that we need to change from getSaveFileName() to
getSaveFileNameAndFilter(). Can you please provide a source explaining the
need for this change?
Thanks,
Ben Root

On Thu, Mar 3, 2011 at 9:36 AM, Benjamin Root <ben...@ou...> wrote:
> As for the sourceforge/github confusion, we are currently in a transition
> phase. Our repository is now hosted on github, but the official website and
> trackers are still sourceforge. Sorry for any confusion there. The
> (un)official new website will be http://matplotlib.github.com.
With particular emphasis on UNofficial. I put that site up to make the
git/github developer docs available right away, and to investigate
whether we might want to host the homepage at github. There has been
no discussion of switching, let alone a decision to do so.

On Thu, Mar 3, 2011 at 3:15 AM, Martin Teichmann <lkb...@gm...>wrote:
> Hi Benjamin, Hi List,
>
> sorry for the backwards patch, here the forward one:
>
> ------------------------------------------------------------------------
> --- backend_qt4_orig.py 2011年03月02日 16:16:38.257797767 +0100
> +++ backend_qt4.py 2011年03月02日 16:17:19.526831397 +0100
> @@ -395,8 +395,9 @@
> filters.append(filter)
> filters = ';;'.join(filters)
>
> - fname = QtGui.QFileDialog.getSaveFileName(
> - self, "Choose a filename to save to", start, filters,
> selectedFilter)
> + fname, _ = QtGui.QFileDialog.getSaveFileNameAndFilter(
> + self, "Choose a filename to save to", start, filters,
> + selectedFilter)
> if fname:
> try:
> self.canvas.print_figure( unicode(fname) )
>
> ----------------------------------------------------------------------------
>
> It is done against a rather old version of matplotlib (the 0.99.3, the
> newest in kubuntu...) but the code hasn't changed since then,
> acording to github, so only the line numbers are wrong.
>
> The second patch I sent is now obsolete, as you hinted to the
> patch on github. I had followed the link on the matplotlib
> web site (http://matplotlib.sourceforge.net/) which links still to
> some subversion repository once you click onto "source code"
> Could please someone update that link to github? Or is there
> a new matplotlib website as well (google didn't find one).
>
> Greetings
>
> Martin
>
> --
> Max-Born-Institut
> Max-Born-Straße 2a
> 12489 Berlin
> +49 30 6392 1234
>
Martin,
Thank you for double-checking your patches. I will see about getting it
added into mpl today.
As for the sourceforge/github confusion, we are currently in a transition
phase. Our repository is now hosted on github, but the official website and
trackers are still sourceforge. Sorry for any confusion there. The
(un)official new website will be http://matplotlib.github.com.
Thank you for helping to make matplotlib better!
Ben Root

Hey,
i just fixed this bug:
http://sourceforge.net/tracker/?func=detail&aid=3165422&group_id=80706&atid=560720
It's a one-liner. I think it's overkill to start a pull request for it.
--- a/lib/matplotlib/axes.py
+++ b/lib/matplotlib/axes.py
@@ -247,7 +247,7 @@ class _process_plot_var_args:
 def _makeline(self, x, y, kw, kwargs):
 kw = kw.copy() # Don't modify the original kw.
- if not 'color' in kw:
+ if not 'color' in kw and not 'color' in kwargs.keys():
 kw['color'] = self.color_cycle.next()
 # (can't use setdefault because it always evaluates
 # its second argument)
it's also attached.
Or do you want to use a pull request?
kind regards
maximilian

Hi Benjamin, Hi List,
sorry for the backwards patch, here the forward one:
------------------------------------------------------------------------
--- backend_qt4_orig.py 2011年03月02日 16:16:38.257797767 +0100
+++ backend_qt4.py 2011年03月02日 16:17:19.526831397 +0100
@@ -395,8 +395,9 @@
 filters.append(filter)
 filters = ';;'.join(filters)
- fname = QtGui.QFileDialog.getSaveFileName(
- self, "Choose a filename to save to", start, filters,
selectedFilter)
+ fname, _ = QtGui.QFileDialog.getSaveFileNameAndFilter(
+ self, "Choose a filename to save to", start, filters,
+ selectedFilter)
 if fname:
 try:
 self.canvas.print_figure( unicode(fname) )
----------------------------------------------------------------------------
It is done against a rather old version of matplotlib (the 0.99.3, the
newest in kubuntu...) but the code hasn't changed since then,
acording to github, so only the line numbers are wrong.
The second patch I sent is now obsolete, as you hinted to the
patch on github. I had followed the link on the matplotlib
web site (http://matplotlib.sourceforge.net/) which links still to
some subversion repository once you click onto "source code"
Could please someone update that link to github? Or is there
a new matplotlib website as well (google didn't find one).
Greetings
Martin
-- 
Max-Born-Institut
Max-Born-Straße 2a
12489 Berlin
+49 30 6392 1234

On Wed, Mar 2, 2011 at 3:00 PM, Ryan May <rm...@gm...> wrote:
> I trust you're going to check in that completely awesome example.
BTW, that completely awesome example was just demoed in front of a
standing-room only audience at the SIAM CSE 11 meeting :) The
matplotlib talk (delivered by yours truly b/c John couldn't make it)
was very well received, the interest in Python here is remarkable.
Cheers,
f