matplotlib-devel Mailing List for matplotlib

Hi,
I have a requirement to make clickable bar charts using the SVG output
(rather than html maps).
An initial look has suggested that the following changes would be required:
backend_bases.py: Add a url property to GraphicsContextBase
(defaulting to None, so it's all backwards compatible)
axes.py: Add a url option to the bar function and pass this on to the
constructor of the Rectangle object
patches.py: Pass the url option in the constructor for the Patch
object to the GraphicsContextBase object created in the draw function
backends/backend_svg.py: Add check to _draw_svg_element for url set in
gc. If it is, write out SVG code for xlink.
I can make these changes and (if people think it would be useful)
contribute the changes back. However, before I do this, I wanted to
check whether this is the right approach to take - I'm not experienced
with the internals of matplotlib and so if there's a better way of
doing it, I'd be grateful for the advice.
Once I got the bar charts working, I would be interested in possibly
extending this to other chart types.
Regards
Andrew

On Wed, Oct 29, 2008 at 4:00 PM, Ryan May <rm...@gm...> wrote:
> Here's probably a better question to ask than just to fix the example.
> Was it intended that the Rectangle.xy attribute disappear? I couldn't
> find it documented in API_CHANGES. It appears that there was just a
> change at some point in Michael's transforms work. If it's considered
> desirable to have it back, I'll volunteer to whip up a patch to make it
> a property. If not, let's just make sure we document this in API_CHANGES.
I have no problem with you adding it back in as a convenience
property. Can't see the harm.
JDH

> Neil Crighton wrote:
>> I noticed on the event handling doc page:
>>
>> mat...@li...
>>
>> that the draggable rectangle example doesn't work in version 0.98.3.
>> The rectangle class no longer seems to have the xy property. If you
>> replace the current on_press() method in the example with the code
>> below it seem to work.
>>
>> def on_press(self, event):
>> 'on button press we will see if the mouse is over us and store
>> some data'
>> if event.inaxes != self.rect.axes: return
>>
>> contains, attrd = self.rect.contains(event)
>> if not contains: return
>> xy = self.rect.get_x(),self.rect.get_y()
>> print 'event contains', xy
>> x0, y0 = xy
>> self.press = x0, y0, event.xdata, event.ydata
>>
Here's probably a better question to ask than just to fix the example.
Was it intended that the Rectangle.xy attribute disappear? I couldn't
find it documented in API_CHANGES. It appears that there was just a
change at some point in Michael's transforms work. If it's considered
desirable to have it back, I'll volunteer to whip up a patch to make it
a property. If not, let's just make sure we document this in API_CHANGES.
My opinion is that randomly breaking API is always bad, and there's not
much effort involved in fixing it here. On the other hand, we've
already had 3 with this breakage, and no complaints up until now (and
that's from our own docs :P)
Thoughts?
Ryan
-- 
Ryan May
Graduate Research Assistant
School of Meteorology
University of Oklahoma

Michiel de Hoon wrote:
> --- On Tue, 10/28/08, Christopher Barker <Chr...@no...>
> wrote:
>> I'm still curious where all this speed comes from.
> At this point, most of it is coming from having complete control over
> the event loop, which allows to avoid superfluous calls to draw().
well, what would be really nice is if we could figure out how to get rid 
of some of this superfluous calls to draw(0 in all the back-ends! I have 
noticed a bunch of extras in wxAgg, but had a hard time untangling it all.
Also, OS-X does double buffer itself, so there may be extra work being 
done there is other back-ends -- essentially triple buffering.
oh well.
-Chris
-- 
Christopher Barker, Ph.D.
Oceanographer
Emergency Response Division
NOAA/NOS/OR&R (206) 526-6959 voice
7600 Sand Point Way NE (206) 526-6329 fax
Seattle, WA 98115 (206) 526-6317 main reception
Chr...@no...

Hi,
I attach a trivial patch to pass a weight argument through hist() to 
histogram().
Cheers,
Olle

Neil Crighton wrote:
> I noticed on the event handling doc page:
> 
> mat...@li...
> 
> that the draggable rectangle example doesn't work in version 0.98.3.
> The rectangle class no longer seems to have the xy property. If you
> replace the current on_press() method in the example with the code
> below it seem to work.
> 
> def on_press(self, event):
> 'on button press we will see if the mouse is over us and store
> some data'
> if event.inaxes != self.rect.axes: return
> 
> contains, attrd = self.rect.contains(event)
> if not contains: return
> xy = self.rect.get_x(),self.rect.get_y()
> print 'event contains', xy
> x0, y0 = xy
> self.press = x0, y0, event.xdata, event.ydata
> 
Good catch. I checked in a slightly different version of the fix.
Ryan
-- 
Ryan May
Graduate Research Assistant
School of Meteorology
University of Oklahoma

--- On Tue, 10/28/08, John Hunter <jd...@gm...> wrote:
> I haven't had a chance to look at the code yet, but I
> suspect he
> hasn't implemented the path collection draw method. If
> it's not
> implemented, we fall back on drawing each path separately,
> which is a
> lot slower. scatter ultimately triggers a call to
> Renderer.draw_path_collection which has a default
> implementation and a
> specialization in backend_agg.
> 
Good point. Indeed I was not aware of the draw_path_collection method and I have not implemented it. I will implement this method and report back with the timings for Eric's example.
Thanks!
--Michiel.