matplotlib-devel Mailing List for matplotlib

(CC'ing list this time)
On Tue, Sep 21, 2010 at 4:30 AM, Dieter Weber <di...@ue...> wrote:
> Hi Ryan,
> well, I was rethinking the patch again after sending it, and I got it
> wrong. :-/ Accessing a deprecated property would give a KeyError with my
> previous patch, as this property is never set. To support deprecated
> options and display warning messages, one needs some kind of custom
> __getitem__ method. I've appended a diff where such a method is created
> "on demand" if the verbosity level is 'helpful' or more.
Which is why I left it to people more familiar with the code to do a
more, ahem, thorough review. Still, I wonder if there's a better way
to maintain the runtime boost without needing a __getitem__...
Need coffee for that.
Ryan
-- 
Ryan May
Graduate Research Assistant
School of Meteorology
University of Oklahoma

On Mon, Sep 20, 2010 at 6:04 PM, Dieter Weber <di...@ue...> wrote:
> Hi,
> I'm currently working on speeding up the legend rendering of matplotlib
> as this turns out to be a bottleneck for my application. With some
> tracing and profiling, I found that
> matplotlib.__init__.RcParams.__getitem__() makes up around 10% of the
> total function calls (by number) in my little test program. It is called
> continuously all over the matplotlib code, whenever a configuration
> parameter is accessed.
>
> Therefore removed the __getitem__ method and moved the key validation to
> a newly written __init__ function, so that validation only happens once
> the object is created, and otherwise the native lookup of the dict()
> class is used. This made my program around 10% faster! :-)
>
> The diff ("svn diff") is appended. If you are interested in the
> profiling results (not only regarding this piece of code), please let me
> know!
First glance looks alright to me, though I haven't looked in heavy
detail. I will defer, however, to those much more familiar with this
code.
Thanks for the patch,
Ryan
-- 
Ryan May
Graduate Research Assistant
School of Meteorology
University of Oklahoma