matplotlib-devel Mailing List for matplotlib

Hello,
why is figure derived from the Artist class?
This causes some special casing (figure is the
only artist where artist.figure does not point to
the figure).
The the figure actually used as an Artist somewhere?
What would break if it would not be derived from
Artist?
I tried the patch
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
diff -u -r1.5 figure.py
--- figure.py 21 Oct 2004 19:57:50 -0000 1.5
+++ figure.py 2 Nov 2004 19:35:03 -0000
@@ -13,7 +13,7 @@
=20
=20
=20
-class Figure(Artist):
+class Figure:
 =20
 def __init__(self,
 figsize =3D None, # defaults to rc figure.figsize
@@ -27,7 +27,7 @@
 paper size is a w,h tuple in inches
 DPI is dots per inch=20
 """
- Artist.__init__(self)
+ #Artist.__init__(self)
 #self.set_figure(self)
=20
 if figsize is None : figsize =3D rcParams['figure.figsize']
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
and everything still seems to work. Maybe a figure
should be just something which uses artists to do its
work instead of being one itself.
What do you think?
Jochen
--=20
http://seehuhn.de/

Hello John,
On Tue, Nov 02, 2004 at 12:41:03PM -0600, John Hunter wrote:
> I think its fine to make the change you suggested -
> while you're in there, I suggest supporting writing to a file object
> as well as a filename, as agg does now. All backends should support
> this.
Done!
All the best,
Jochen
--=20
http://seehuhn.de/

Hello John,
On Tue, Nov 02, 2004 at 12:49:28PM -0600, John Hunter wrote:
> I don't know why is was changed (or what it was before).
I think it was just a misunderstanding about how error reporting
is supposed to work.
> def error_msg_template(msg, *args):
> """
> Signal an error condition.
> - in a GUI backend, popup a error dialog.
> - in a non-GUI backend delete this function and use
> 'from matplotlib.backend_bases import error_msg'
> """
> verbose.report_error(msg)
> raise SystemExist
>=20
> All opposed, say Nay!
I agree with the code, but I am not the sure about the comment.
All the best,
Jochen
--=20
http://seehuhn.de/

>>>>> "Jochen" == Jochen Voss <vo...@se...> writes:
 Jochen> Then the recent change to error_msg_template should be
 Jochen> reverted, shouldn't it?
I don't know why is was changed (or what it was before). I just
checked in 
def error_msg_template(msg, *args):
 """
 Signal an error condition.
 - in a GUI backend, popup a error dialog.
 - in a non-GUI backend delete this function and use
 'from matplotlib.backend_bases import error_msg'
 """
 verbose.report_error(msg)
 raise SystemExist
All opposed, say Nay!
JDH

>>>>> "Jochen" == Jochen Voss <vo...@se...> writes:
 Jochen> Is there a reason for storing the PostScript data in a
 Jochen> string first? Otherwise I could just pass the real file
 Jochen> handle to RendererPS and it would write all the stuff
 Jochen> directly into the output file.
The reason I did it (I think) was for efficiency, (wrongly) thinking
it would be faster to write to StringIO than to a file object. Of
course, file objects buffer their output, so this is not a real
consideration. I think its fine to make the change you suggested -
while you're in there, I suggest supporting writing to a file object
as well as a filename, as agg does now. All backends should support
this.
JDH

Hello,
the current way the PostScript backend works is as follows:
 1) FigureCanvasPS.print_figure() uses StringIO to make a string look like
 a file.
 2) The RendererPS class writes the PostScript file (except for the header=
s)
 into this string, using file operations. This is done via call to
 Figure.draw()
 3) FigureCanvasPS.print_figure() writes the resulting string into the
 output file.
Is there a reason for storing the PostScript data in a string first?
Otherwise I could just pass the real file handle to RendererPS and it
would write all the stuff directly into the output file.
All the best,
Jochen
--=20
http://seehuhn.de/

Hello,
On Sun, Oct 31, 2004 at 10:33:27AM -0600, John Hunter wrote:
> >> 7) The template backend uses=3D20
> >>=20
> >> verbose.report('Error: %s'%msg)
> >>=20
> >> Should this be 'verbose.report_error' instead?
>=20
> Yes.
>=20
> Steve> No verbose() at all! But I agree I think it should be
> Steve> 'verbose.report_error'
>=20
> Yes, it should. All printing should either go to verbose.report or
> verbose.report_error, so that the user specified output handles are
> used. This was just an oversight in backend_bases.error_msg.
> Everyone should feel free to fix these as they find them.
Then the recent change to error_msg_template should be reverted,
shouldn't it?
All the best,
Jochen
--=20
http://seehuhn.de/