matplotlib-devel Mailing List for matplotlib

On Oct 17, 2008, at 7:29 AM, John Hunter wrote:
> Hey Tony,
>
> Thanks for the patch, applied to svn r6232. For future patches, could
> you send a "svn diff" from the matplotlib directory containing
> setup.py. That way I don't have to think too hard about the patch
> level, what kind of patch it is etc
Doh, I think you mentioned this to me before. Sorry about that.
> Thanks again,
> JDH

On Wed, Oct 15, 2008 at 2:57 PM, Manuel Metz <mm...@as...> wrote:
> I found a few typos in artists.rst. Added a patch (don't want to commit
> it, because I'm not actively working on the docs)
>
> The first sentence of the section "Object containers" also needs to be
> fixed (or I don't understand it):
> "Now that we know how to inspect set the properties of a given object
> we want to configure, we need to now how to get at that object."
>
> "inspect" or "set" ???
"inspect and set"
Thanks for the patch -- I just applied it to svn r6234
JDH

Jae-Joon Lee wrote:
> Thanks Manuel.
> 
> Yes, we need rotation value and etc, but my point is, do we need to
> update it within the update_from() method? Although my preference is
> not to do it, it may not matter much as far as we state what this
> method does clearly in the doc.
Okay, it's probably better to create the object correctly (numsides ...)
instead of copying the properties (see also JDHs mail !)
> And, in your patch, I don't think updating the numsides value has any
> effect as it does not recreate the paths.
> 
> I'm attaching the revised patch. In this patch, update_from() only
> update gc-related properties. And numsides, size, and rotations are
> given during the object creation time.
Yes, this looks better. But creating handle_sizes is a little bit too
much effort. This is done internally. It will do passing a sizes list,
that may or may not be shorter/longer than numpoints (see revised patch).
I also changed the way the yoffsets are updated in _update_positions().
One additional thing I have in mind (for a later time) is a "sizesbar"
similar to a colorbar where you can read off values corresponding to
marker sizes...
Cheers,
 Manuel
> Erik,
> I see your points. My main concern is that the yoffsets makes the
> results a bit funny when numpoints is 2. The attached patch has a
> varying sizes of [0.5*(max+min), max, min]. The yoffsets are only
> introduced when numpints > 2 and you can also provide it as an
> optional argument.
> 
> Regards,
> 
> -JJ
> 
> 
> On Thu, Oct 16, 2008 at 8:43 PM, Manuel Metz <mm...@as...> wrote:
>> Manuel Metz wrote:
>>> Jae-Joon Lee wrote:
>>>> Hi Manuel,
>>>>
>>>> I think it is a good to introduce the update_from method in Collections.
>>>> But, I'm not sure if it is a good idea to also update sizes, paths and
>>>> rotation (in RegularPolyCoolection). My impression is that update_from
>>>> method is to update gc related attributes. For comparison,
>>>> Patch.update_from() does not update the path.
>>> That's exactly the point why I wasn't fully happy with the patch. The
>>> path is generated by the _path_generator, so instead of copying the path
>>> it seems to be better to create an instance of the corresponding class
>>> (e.g. the StarPolygonCollection class, as suggested before).
>>>
>>> One should update the rotation attribute (!!); it's only one number. A
>>> '+' marker, for example, has rotation = 0, whereas a 'x' marker has
>>> rotation=pi/4. That's the only difference between those two !
>>>
>>>> Also, is it okay to update properties without checking its length?. It
>>>> does not seem to cause any problems though.
>>> It's in principal not a problem to copy the sizes attribute without
>>> checking the length. If it's shorter the the number of items the sizes
>>> are repeated; if it's longer it gets truncated.
>>>
>>> mm
>>>
>>>> I guess It would better to use xdata_markers than xdata in the
>>>> get_handle() method. The difference is when numpoints==1. Using xdata
>>>> gives two marker points.
>>>>
>>>> I was actually about to to commit my patch. I'll try to account your
>>>> changes and post my version of patch later today.
>>>>
>>>> Regards,
>>>>
>>>> -JJ
>>>>
>>>>
>>>>
>>>>
>>>> On Wed, Oct 15, 2008 at 4:07 PM, Manuel Metz <mm...@as...> wrote:
>>>>> hmm
>>>>>
>>>>> -------- Original Message --------
>>>>> Jae-Joon Lee wrote:
>>>>>>> - the parameter numpoints should be used (it's ignored right now)
>>>>>>>
>>>>>> Thanks Manuel. I guess we can simply reuse xdata_marker for this purpose.
>>>>>>
>>>>>>
>>>>>>> - Some private variables are accessed and a new RegularPolycollection is
>>>>>>> created (does this work eg. with a StarPolygonCollection? I haven't
>>>>>>> checked, but I don't think so !). Instead of creating a new
>>>>>>> RegularPolyCollection it might be more useful to make a copy of the
>>>>>>> existing object... I was thinking about a update_from() method for the
>>>>>>> Collection class(es) similar to update_from() for lines.
>>>>>>>
>>>>>> By changing "RegularPolyCoolection" to "type(handles)", it works for
>>>>>> StarPolygonCollection.
>>>>>>
>>>>>> In Erik's current implementation, the markers in the legend have
>>>>>> varying colors, sizes, and y offsets.
>>>>>> The color variation seems fine. But do we need to vary the sizes and
>>>>>> y-offsets? My inclination is to use a fixed size (median?) and a fixed
>>>>>> y offset. How does Erik and others think?
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> -JJ
>>>>> Attached is my current version of the patch. I've moved all of the
>>>>> properties-copying stuff to collections, which makes the changes
>>>>> legend.py more clearer (but I'm not fully happy with the patch and
>>>>> haven't commit anything yet)
>>>>>
>>>>> mm
>>>>>
>> Hi Jae-Joon,
>> so here is my revised version of the patch. What do you think ?
>>
>> Manuel
>>
>>

On Thu, Oct 16, 2008 at 9:10 PM, Tony S Yu <to...@mi...> wrote:
> I noticed that one of the animation examples is missing some import
> statements. Also, the diff below includes a small change to the shebang line
> of another example.
Hey Tony,
Thanks for the patch, applied to svn r6232. For future patches, could
you send a "svn diff" from the matplotlib directory containing
setup.py. That way I don't have to think too hard about the patch
level, what kind of patch it is etc
 > cd ~/path/to/mpl/src
 > svn diff > mypatch.diff
Thanks again,
JDH

On Thu, Oct 16, 2008 at 9:57 PM, Jae-Joon Lee <lee...@gm...> wrote:
> Thanks Manuel.
>
> Yes, we need rotation value and etc, but my point is, do we need to
> update it within the update_from() method? Although my preference is
> not to do it, it may not matter much as far as we state what this
> method does clearly in the doc.
To help clarify the original purpose of "update_from": I wrote this
method when writing the original legend implementation so the legend
proxy objects could easily copy their style attributes from the
underlying objects they were a proxy for (so not every property is
copied, eg the xdata for line objects is not copied). So the
operating question should be: what properties do I need to copy to
make the legend representation of the object. While you are in
there, perhaps you could clarify this in the docstrings of the
update_from method.
Hope this helps,
JDH

On Thu, Oct 16, 2008 at 5:10 PM, Darren Dale <dar...@co...> wrote:
> It looks great, really nice work guys. Sorry I havent been able to keep up
> with the list recently, unfortunately its unlikely to change for a while.
>
> I noticed that the PDF download link at
> http://matplotlib.sourceforge.net/contents.html is broken.
Ahh, thanks for letting me know. It's fixed now (you may need to
"refresh"). sf removed shell access to the web directory, so all the
reorg and cleanup had to be done over sftp, scp and rsync via ssh,
which was a pain, so there are probably a few things that will need to
be restored/tweaked.
JDH

On Thu, Oct 16, 2008 at 9:18 PM, Paul Ivanov <piv...@gm...> wrote:
> Hi,
>
> I'm a big fan of keyboard shortcuts, so I decided to add these guys to
> lib/matplotlib/backend_bases.py
>
> I'm not sure if this is too much, and maybe these should be configurable
> down the line, but here's my first stab at it, what do you all think?
>
> in the same order as they appear in the toolbar:
> 'h' or 'r' for Home/Reset
> left arrow or 'z' or backspace for Back
> right arrow and 'x' for Forward
> 'p' for pan axes with right, zoom with left mode toggle
> 'o' for z*o*om to rectangle mode toggle
> 's' for save
> 'z' and 'x' I borrowed from the Opera browser, very handy to for
> righties who can have their left hand on the keyboard while using the mouse.
Hi Paul,
I'm amenable to additional keys, but check out
http://matplotlib.sourceforge.net/users/navigation_toolbar.html which
details which keys are already in play. Also, with your patch, please
submit a patch against the navigation toolbar doc
doc/users/navigation_toolbar.rst . Maybe a ReST table that details all
of the key bindings?
Thanks,
JDH

Paul Ivanov schrieb:
> Hi,
>
> I'm a big fan of keyboard shortcuts, so I decided to add these guys to
> lib/matplotlib/backend_bases.py	
>
> I'm not sure if this is too much, and maybe these should be configurable
> down the line, but here's my first stab at it, what do you all think?
>
> in the same order as they appear in the toolbar:
> 'h' or 'r' for Home/Reset
> left arrow or 'z' or backspace for Back
> right arrow and 'x' for Forward
> 'p' for pan axes with right, zoom with left mode toggle
> 'o' for z*o*om to rectangle mode toggle
> 's' for save
> 
I like this idea very much. What I would like to see is panning 
associated with the space bar, like it's done in Adobe Acrobat: panning 
is only activated _while_ you press space. I think this is more 
difficult to implement. Once I had a quick look at it and abandonded 
this project, it was too complicated for me. Perhaps you can manage this?
> 'z' and 'x' I borrowed from the Opera browser, very handy to for
> righties who can have their left hand on the keyboard while using the mouse.
> 
On german keyboards y and z are exchanged. Having these keys 
configurable would be handy.
Gregor

Thanks Manuel.
Yes, we need rotation value and etc, but my point is, do we need to
update it within the update_from() method? Although my preference is
not to do it, it may not matter much as far as we state what this
method does clearly in the doc.
And, in your patch, I don't think updating the numsides value has any
effect as it does not recreate the paths.
I'm attaching the revised patch. In this patch, update_from() only
update gc-related properties. And numsides, size, and rotations are
given during the object creation time.
Erik,
I see your points. My main concern is that the yoffsets makes the
results a bit funny when numpoints is 2. The attached patch has a
varying sizes of [0.5*(max+min), max, min]. The yoffsets are only
introduced when numpints > 2 and you can also provide it as an
optional argument.
Regards,
-JJ
On Thu, Oct 16, 2008 at 8:43 PM, Manuel Metz <mm...@as...> wrote:
> Manuel Metz wrote:
>> Jae-Joon Lee wrote:
>>> Hi Manuel,
>>>
>>> I think it is a good to introduce the update_from method in Collections.
>>> But, I'm not sure if it is a good idea to also update sizes, paths and
>>> rotation (in RegularPolyCoolection). My impression is that update_from
>>> method is to update gc related attributes. For comparison,
>>> Patch.update_from() does not update the path.
>>
>> That's exactly the point why I wasn't fully happy with the patch. The
>> path is generated by the _path_generator, so instead of copying the path
>> it seems to be better to create an instance of the corresponding class
>> (e.g. the StarPolygonCollection class, as suggested before).
>>
>> One should update the rotation attribute (!!); it's only one number. A
>> '+' marker, for example, has rotation = 0, whereas a 'x' marker has
>> rotation=pi/4. That's the only difference between those two !
>>
>>> Also, is it okay to update properties without checking its length?. It
>>> does not seem to cause any problems though.
>>
>> It's in principal not a problem to copy the sizes attribute without
>> checking the length. If it's shorter the the number of items the sizes
>> are repeated; if it's longer it gets truncated.
>>
>> mm
>>
>>> I guess It would better to use xdata_markers than xdata in the
>>> get_handle() method. The difference is when numpoints==1. Using xdata
>>> gives two marker points.
>>>
>>> I was actually about to to commit my patch. I'll try to account your
>>> changes and post my version of patch later today.
>>>
>>> Regards,
>>>
>>> -JJ
>>>
>>>
>>>
>>>
>>> On Wed, Oct 15, 2008 at 4:07 PM, Manuel Metz <mm...@as...> wrote:
>>>> hmm
>>>>
>>>> -------- Original Message --------
>>>> Jae-Joon Lee wrote:
>>>>>> - the parameter numpoints should be used (it's ignored right now)
>>>>>>
>>>>> Thanks Manuel. I guess we can simply reuse xdata_marker for this purpose.
>>>>>
>>>>>
>>>>>> - Some private variables are accessed and a new RegularPolycollection is
>>>>>> created (does this work eg. with a StarPolygonCollection? I haven't
>>>>>> checked, but I don't think so !). Instead of creating a new
>>>>>> RegularPolyCollection it might be more useful to make a copy of the
>>>>>> existing object... I was thinking about a update_from() method for the
>>>>>> Collection class(es) similar to update_from() for lines.
>>>>>>
>>>>> By changing "RegularPolyCoolection" to "type(handles)", it works for
>>>>> StarPolygonCollection.
>>>>>
>>>>> In Erik's current implementation, the markers in the legend have
>>>>> varying colors, sizes, and y offsets.
>>>>> The color variation seems fine. But do we need to vary the sizes and
>>>>> y-offsets? My inclination is to use a fixed size (median?) and a fixed
>>>>> y offset. How does Erik and others think?
>>>>>
>>>>> Regards,
>>>>>
>>>>> -JJ
>>>> Attached is my current version of the patch. I've moved all of the
>>>> properties-copying stuff to collections, which makes the changes
>>>> legend.py more clearer (but I'm not fully happy with the patch and
>>>> haven't commit anything yet)
>>>>
>>>> mm
>>>>
>
> Hi Jae-Joon,
> so here is my revised version of the patch. What do you think ?
>
> Manuel
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Matplotlib-devel mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
>
>

Hi,
I'm a big fan of keyboard shortcuts, so I decided to add these guys to
lib/matplotlib/backend_bases.py	
I'm not sure if this is too much, and maybe these should be configurable
down the line, but here's my first stab at it, what do you all think?
in the same order as they appear in the toolbar:
'h' or 'r' for Home/Reset
left arrow or 'z' or backspace for Back
right arrow and 'x' for Forward
'p' for pan axes with right, zoom with left mode toggle
'o' for z*o*om to rectangle mode toggle
's' for save
'z' and 'x' I borrowed from the Opera browser, very handy to for
righties who can have their left hand on the keyboard while using the mouse.
I decided to use 'o' for zoom to rect since it's located right next to
the 'p' for panning, and both are modes.
There was also a message on the matplotlib-users list in July that this
patch would be useful for
Subj: [Matplotlib-users] tool bar help / feature request
From: Ben Axelrod <baxelrod@co...> - 2008年07月31日 16:08
(but I don't know how to reply to that message as I was not on the the
users list at that time)
cheers,
Paul Ivanov

I noticed that one of the animation examples is missing some import 
statements. Also, the diff below includes a small change to the 
shebang line of another example.
Cheers,
-Tony