matplotlib-devel Mailing List for matplotlib

On 2/14/07, John Hunter <jd...@gm...> wrote:
> On 2/14/07, Paul Barrett <peb...@gm...> wrote:
>
> > I still feel this way, but maybe I should change my tune and let the
> > changes go in.
>
> What do you think about the comments made earlier in this thread:
My first reply:
 I suggest that this patch not be applied, since this was the intended
behavior when the font manager was implemented. The standard behavior
for indicating a missing character is to print a square. In addition,
if a space is printed, how will you know when the formatting is
correct or not. The unanticipated space could mean font is missing
that character, or the layout manager has a bug?
and second reply:
If my memory ser ves me correctly - or if the implementation has
changed over the past few years - get_charmap() is a wrapper on the
FreeType method. FreeType had no reverse mapping and creating one may
have caused problems later.
I prefer the second alternative. If FreeType now has a reverse
mapping, then by all means create a wrapper for it. If not, then you
will need to take some care that get_rcharmap is reasonably future
proof, so that it does cause maintenance problem later on.
> > FT2Font.get_charmap() returns a mapping from glyph index to character code.
> > This looks like a very bad design decision to me, because several character
> > codes can correspond to one glyph. For example, in Times New Roman, both 0x32
> > (space) and 0xA0 (nbsp) are mapped to glyph index 3. Of course, the first one
> > gets lost in get_charmap().
>
> I don't remember why we did it this way originally, or if was you or I
> who did it, but if it is correct that the mapping is sometimes many
> codes point to one one glyph index, but there each glyph index must
> point to a single character code (the latter must be correct, right?)
> then reversing it seems to be the right course. But it's been a long
> time since I delved into freetype internals ...
I think I did it. At the time the reverse mapping seemed the best
approach, since this ultimately is what the code demanded. (I guess
my memory has failed me!) We also did not have any examples of the
many to one mapping. As you state, this has now changed and the
latter must be correct. This now explains the FreeType implementation.
 -- Paul

On 2/14/07, Michiel Jan Laurens de Hoon <md...@c2...> wrote:
> Dear Charles,
>
> I was trying to use your cocoa-agg backend for matplotlib, but it seems
> to have a problem to read Matplotlib.nib. Opening this nib with
> Interface Builder also gives an error. It appears that the problem is
> caused by the file keyedobjects.nib in the Matplotlib.nib folder. If I
> run plutil on keyedobjects.nib, it crashes. The other two files in
> Matplotlib.nib look fine. So I was wondering if it is possible that the
> keyedobjects.nib file included in matplotlib is damaged. If so, do you
> have a valid copy of this file?
>
> Many thanks in advance,
>
> --Michiel de Hoon.
We recently moved the data files, and I think the nib files got
interpreted as text instead of binary files. I grabbed an old copy
from a previous source release and committed them as binary. They
should work now.
- Charlie

On 2/14/07, Paul Barrett <peb...@gm...> wrote:
> I still feel this way, but maybe I should change my tune and let the
> changes go in.
What do you think about the comments made earlier in this thread:
> FT2Font.get_charmap() returns a mapping from glyph index to character code.
> This looks like a very bad design decision to me, because several character
> codes can correspond to one glyph. For example, in Times New Roman, both 0x32
> (space) and 0xA0 (nbsp) are mapped to glyph index 3. Of course, the first one
> gets lost in get_charmap().
I don't remember why we did it this way originally, or if was you or I
who did it, but if it is correct that the mapping is sometimes many
codes point to one one glyph index, but there each glyph index must
point to a single character code (the latter must be correct, right?)
then reversing it seems to be the right course. But it's been a long
time since I delved into freetype internals ...
JDH

John,
I still feel this way, but maybe I should change my tune and let the
changes go in.
 -- Paul
On 2/14/07, John Hunter <jd...@gm...> wrote:
> On 2/14/07, Evgeniy Stepanov <eug...@gm...> wrote:
>
> > I also prefer the first way. Here is the patch. Please re-check at least the
> > changes to mathtext.py, I could miss something. mathtext_demo.py still works,
> > but it obviously does not test all the changes.
>
> Thanks for looking into this -- last time Nicolas brought this up back
> in November, Paul argued that reversing the dictionary "violated the
> principle of least surprise" but clearly you two disagree. If Paul is
> still monitoring this, he can weig in again if he still objects to the
> reversal. You should try tunning examples/backend_driver and looking
> at as many of the PS and PNG outputs as you can to make sure the text
> looks right, and then send on a final patch if any revisions are
> needed and one of us can see to it that it gets incorporated.
>
> JDH
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Matplotlib-devel mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
>

On 2/14/07, Evgeniy Stepanov <eug...@gm...> wrote:
> I also prefer the first way. Here is the patch. Please re-check at least the
> changes to mathtext.py, I could miss something. mathtext_demo.py still works,
> but it obviously does not test all the changes.
Thanks for looking into this -- last time Nicolas brought this up back
in November, Paul argued that reversing the dictionary "violated the
principle of least surprise" but clearly you two disagree. If Paul is
still monitoring this, he can weig in again if he still objects to the
reversal. You should try tunning examples/backend_driver and looking
at as many of the PS and PNG outputs as you can to make sure the text
looks right, and then send on a final patch if any revisions are
needed and one of us can see to it that it gets incorporated.
JDH

On Wednesday 14 February 2007 21:53, Nicolas Grilly wrote:
> On 2/14/07, Evgeniy Stepanov <eug...@gm...> wrote:
> > FT2Font.get_charmap() returns a mapping from glyph index to character
> > code. This looks like a very bad design decision to me, because several
> > character codes can correspond to one glyph. For example, in Times New
> > Roman, both 0x32 (space) and 0xA0 (nbsp) are mapped to glyph index 3. Of
> > course, the first one gets lost in get_charmap().
> >
> > I think, get_charmap should be fixed to return mapping from character
> > codes to glyph indices. Alternatively, get_charmap() could be left as it
> > is, and get_rcharmap() added.
>
> I agree with you. I've already posted something about this issue some
> time ago: http://sourceforge.net/mailarchive/message.php?msg_id=37418828
>
> > I'm willing to implement either one. Which do you prefer ?
>
> I think we should prefer the first alternative: I've made a quick grep
> through matplotlib's code and I've observed that each time get_charmap
> is called, the returned dict is never used as is, but immediately
> reversed.
I also prefer the first way. Here is the patch. Please re-check at least the 
changes to mathtext.py, I could miss something. mathtext_demo.py still works, 
but it obviously does not test all the changes.

On 2/14/07, Evgeniy Stepanov <eug...@gm...> wrote:
> FT2Font.get_charmap() returns a mapping from glyph index to character code.
> This looks like a very bad design decision to me, because several character
> codes can correspond to one glyph. For example, in Times New Roman, both 0x32
> (space) and 0xA0 (nbsp) are mapped to glyph index 3. Of course, the first one
> gets lost in get_charmap().
>
> I think, get_charmap should be fixed to return mapping from character codes to
> glyph indices. Alternatively, get_charmap() could be left as it is, and
> get_rcharmap() added.
I agree with you. I've already posted something about this issue some
time ago: http://sourceforge.net/mailarchive/message.php?msg_id=37418828
> I'm willing to implement either one. Which do you prefer ?
I think we should prefer the first alternative: I've made a quick grep
through matplotlib's code and I've observed that each time get_charmap
is called, the returned dict is never used as is, but immediately
reversed.
-- Nicolas Grilly

Sorry, I was too hasty. The patch is wrong, here is the real reason:
FT2Font.get_charmap() returns a mapping from glyph index to character code. 
This looks like a very bad design decision to me, because several character 
codes can correspond to one glyph. For example, in Times New Roman, both 0x32 
(space) and 0xA0 (nbsp) are mapped to glyph index 3. Of course, the first one 
gets lost in get_charmap().
I think, get_charmap should be fixed to return mapping from character codes to 
glyph indices. Alternatively, get_charmap() could be left as it is, and 
get_rcharmap() added.
I'm willing to implement either one. Which do you prefer ?

On 2/14/07, John Hunter <jd...@gm...> wrote:
> Apparently all we have to do is include the README along with the
> licensing terms. You probably should do that in the the same
> directory the fonts live to ensure that they are always distributed
> together. We also have a licenses directory.
In this purpose, I've provided a readme.txt file, located in the same
directory as the AFM files, and containing this text:
"""
 Font Metrics for the 14 PDF Core Fonts
 ======================================
 This directory contains font metrics for the 14 PDF Core Fonts (files with .afm
 extension), downloaded from
http://partners.adobe.com/public/developer/font/index.html.
 This file and the 14 PostScript(R) AFM files it accompanies may be
used, copied,
 and distributed for any purpose and without charge, with or without
modification,
 provided that all copyright notices are retained; that the AFM files are not
 distributed without this file; that all modifications to this file or any of
 the AFM files are prominently noted in the modified file(s); and that this
 paragraph is not modified. Adobe Systems has no responsibility or obligation
 to support the use of the AFM files.
"""
The original file from Adobe just contained the last paragraph; I
added the first one to make clear the files origin.
NG

On 2/14/07, Nicolas Grilly <nic...@ga...> wrote:
> I hope there is no license issue with the AFM files. I'm pretty sure
> I've seen them integrated in some TeX distributions.
Apparently all we have to do is include the README along with the
licensing terms. You probably should do that in the the same
directory the fonts live to ensure that they are always distributed
together. We also have a licenses directory.
JDH

T24gMi8xNC8wNywgSm91bmkgSy4gU2VwcMOkbmVuIDxqa3NAaWtpLmZpPiB3cm90ZToKPiBUaGFu
a3M7IG9uIGZpcnN0IGxvb2sgdGhpcyBzZWVtcyByZWFsbHkgbmljZSEgU28gZmFyIEkgaGF2ZSBv
bmUKPiByZXF1ZXN0IHRvIHlvdSBhbmQgb25lIHRvIEpvaG46CgpZb3UncmUgd2VsY29tZTsgSSdt
IGhhcHB5IHRvIGNvbnRyaWJ1dGUgdG8gbWF0cGxvdGxpYiB3aGVuIEkgY2FuISA6LSkKCj4gTmlj
b2xhczogd291bGQgaXQgYmUgZWFzeSBmb3IgeW91IHRvIHN0cmlwIHRoZSBeTSAoY2FycmlhZ2Ut
cmV0dXJuKQo+IGNoYXJhY3RlcnMgZnJvbSB5b3VyIGZpbGVzIGFuZCB0aGVuIHJlLXJ1biBkaWZm
PyBJIHNlZSBpbiB5b3VyIHBhdGNoCj4gc2V2ZXJhbCBwYXJ0cyB3aGVyZSB0aGUgb25seSBjaGFu
Z2Ugc2VlbXMgdG8gYmUgYW4gYWRkaXRpb24gb2YgXk0gYXQKPiB0aGUgZW5kIG9mIGVhY2ggbGlu
ZSwgYnV0IHRoZXJlIGNvdWxkIGJlIHNpZ25pZmljYW50IGNoYW5nZXMgaGlkZGVuCj4gd2l0aGlu
IHRoZXNlIHBhcnRzLiAoUGVyaGFwcyBqdXN0IGdpdmUgdGhlIC1iIG9wdGlvbiB0byBkaWZmPyBU
aG91Z2gKPiB0aGF0IG1pZ2h0IGJhY2tmaXJlIGlmIHNvbWUgb3RoZXIgd2hpdGVzcGFjZSBjaGFu
Z2VzIGFyZSBzaWduaWZpY2FudCwKPiBlLmcuIGlmIHlvdSBoYXZlIGNoYW5nZWQgdGhlIGluZGVu
dGF0aW9uIG9mIHNvbWUgY29kZSBibG9ja3MuKQoKT2suIEkndmUgcmVtb3ZlZCB0aGUgY2Fycmlh
Z2UtcmV0dXJuIGNoYXJhY3RlcnMgYW5kIGFkZGVkIHByb3BlcnR5CnN2bjplb2wtc3R5bGUgPSBu
YXRpdmUgdG8gYmFja2VuZC5wZGYuIE5vdyB0aGUgcGF0Y2ggbG9va3MgcmlnaHQgKHNlZQp0aGUg
YXR0YWNoZWQgZmlsZSkuCgpJIGhvcGUgdGhlcmUgaXMgbm8gbGljZW5zZSBpc3N1ZSB3aXRoIHRo
ZSBBRk0gZmlsZXMuIEknbSBwcmV0dHkgc3VyZQpJJ3ZlIHNlZW4gdGhlbSBpbnRlZ3JhdGVkIGlu
IHNvbWUgVGVYIGRpc3RyaWJ1dGlvbnMuCgotLSBOaWNvbGFzIEdyaWxseQo=

Hi,
currently, PS backend does not work well with some fonts. For
instance, it displays a dotted square instead of whitespace with
Arial, and some strange dots instead of whitespace with Times New
Roman. This patch fixes it by omitting glyphs named ".notdef" from PS
output.

"Nicolas Grilly" <nic...@ga...> writes:
> Here is a patch I promised some time ago, to improve the PDF backend.
Thanks; on first look this seems really nice! So far I have one
request to you and one to John:
Nicolas: would it be easy for you to strip the ^M (carriage-return)
characters from your files and then re-run diff? I see in your patch
several parts where the only change seems to be an addition of ^M at
the end of each line, but there could be significant changes hidden
within these parts. (Perhaps just give the -b option to diff? Though
that might backfire if some other whitespace changes are significant,
e.g. if you have changed the indentation of some code blocks.)
John: Is Adobe's licensing of the AFM files compatible with
matplotlib's license? I think it is, but I'm no license expert. The
readme file distributed with the files contains the following text:
 Font Metrics for the 14 PDF Core Fonts
 ======================================
 This directory contains font metrics for the 14 PDF Core Fonts (files with .afm 
 extension), downloaded from http://partners.adobe.com/public/developer/font/index.html.
 This file and the 14 PostScript(R) AFM files it accompanies may be used, copied, 
 and distributed for any purpose and without charge, with or without modification, 
 provided that all copyright notices are retained; that the AFM files are not 
 distributed without this file; that all modifications to this file or any of 
 the AFM files are prominently noted in the modified file(s); and that this 
 paragraph is not modified. Adobe Systems has no responsibility or obligation 
 to support the use of the AFM files.
-- 
Jouni K. Seppänen
http://www.iki.fi/jks