matplotlib-devel Mailing List for matplotlib

On Tue, Sep 13, 2011 at 1:11 PM, Eric Firing <ef...@ha...> wrote:
> On 09/13/2011 02:19 AM, Pim Schellart wrote:
> > Dear Eric (and other developers),
> >
> > I have implemented the requested changes and the resulting diff can be
> > seen at
> https://github.com/pschella/matplotlib/compare/master...cubehelix
> > I tried to do a better job at documentation and hope this is
> > sufficient, let me know if something is missing.
>
> Pim,
>
> I haven't tried it yet, but the code looks nice! Go ahead and click
> your "pull request" button so that it shows up on the main matplotlib
> repo list of pull requests.
>
> > I'm not sure exactly what you meant with your suggestion to define
> > named functions inside the main function body but I hope my new
> > implementation more closely matches your wishes.
>
> It does. I did not recognize that only a single function was needed.
>
> > I have opted for a factory function within the main function to avoid
> > the code duplication associated with creating a named function for
> > each color component.
>
> Good!
>
> Eric
>
>
We shouldn't forget to add mention of this new colormap to the What's New
page.
Ben Root

On 09/13/2011 02:19 AM, Pim Schellart wrote:
> Dear Eric (and other developers),
>
> I have implemented the requested changes and the resulting diff can be
> seen at https://github.com/pschella/matplotlib/compare/master...cubehelix
> I tried to do a better job at documentation and hope this is
> sufficient, let me know if something is missing.
Pim,
I haven't tried it yet, but the code looks nice! Go ahead and click 
your "pull request" button so that it shows up on the main matplotlib 
repo list of pull requests.
> I'm not sure exactly what you meant with your suggestion to define
> named functions inside the main function body but I hope my new
> implementation more closely matches your wishes.
It does. I did not recognize that only a single function was needed.
> I have opted for a factory function within the main function to avoid
> the code duplication associated with creating a named function for
> each color component.
Good!
Eric
>
> Kind regards,
>
> Pim Schellart
>
> P.S. Sorry for submitting the patch directly on the mailing list
> before, I simply followed the link on how to contribute from the
> matplotlib FAQ and didn't look at what was stated above the section
> scrolled to automatically (maybe something to change).
>
> ------------------------------------------------------------------------------
> BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
> Learn about the latest advances in developing for the
> BlackBerry® mobile platform with sessions, labs& more.
> See new tools and technologies. Register for BlackBerry® DevCon today!
> http://p.sf.net/sfu/rim-devcon-copy1
> _______________________________________________
> Matplotlib-devel mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel

Dear Sameer,
I had a quick look at the paper and this scheme seems useful as well.
I'm willing to implement the general conversion functions for this
scheme as well if and when I have some time left.
But only after cubehelix is approved so I know what the format should be.
If you already have code to do it that would be even better of course.
Kind regards,
Pim Schellart

Dear Eric (and other developers),
I have implemented the requested changes and the resulting diff can be
seen at https://github.com/pschella/matplotlib/compare/master...cubehelix
I tried to do a better job at documentation and hope this is
sufficient, let me know if something is missing.
I'm not sure exactly what you meant with your suggestion to define
named functions inside the main function body but I hope my new
implementation more closely matches your wishes.
I have opted for a factory function within the main function to avoid
the code duplication associated with creating a named function for
each color component.
Kind regards,
Pim Schellart
P.S. Sorry for submitting the patch directly on the mailing list
before, I simply followed the link on how to contribute from the
matplotlib FAQ and didn't look at what was stated above the section
scrolled to automatically (maybe something to change).

On 07/18/2011 07:07 AM, Sameer Grover wrote:
> I came across this website where different colormaps have been compared
> and the author has come up with an optimal colormap for data
> visualization called the "cool-warm colormap".
>
> http://www.cs.unm.edu/~kmorel/documents/ColorMaps/index.html
>
> It is somewhat similar to the cool colormap already included in
> matplotlib, but I've added the new colormap to matplotlib in the patch
> attached in case it is deemed fit to be included in the matplotlib source.
>
> Regards,
> Sameer
Sameer,
We should include this, but I think the 257-entry version is overkill; 
it adds a big chunk to the _cm.py file, and I doubt it is visually 
distinguishable from the 33-entry version. Would you mind providing a 
patch for the latter? (Or better yet, the functions that generate the 
r,g,b values.)
Thank you.
Eric
>
>
>
> ------------------------------------------------------------------------------
> AppSumo Presents a FREE Video for the SourceForge Community by Eric
> Ries, the creator of the Lean Startup Methodology on "Lean Startup
> Secrets Revealed." This video shows you how to validate your ideas,
> optimize your ideas and identify your business strategy.
> http://p.sf.net/sfu/appsumosfdev2dev
>
>
>
> _______________________________________________
> Matplotlib-devel mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel