matplotlib-devel Mailing List for matplotlib

Here is my first attempt at patch submission. This patch aims to make
it possible to set legend properties (like fontsize) in the
matplotlibrc file.
Details:
 added legend options to rc file
To the main __init__.py file I have added lines 769-780
to set default
rc values for legend related parameters. The attached
matplotlibrc
file is just an example of setting the legend parameters.
There are several changes to legend.py:
1. added ,rcParams to the end of line 29:
from matplotlib import verbose, rcParams
2. lines 112-124 set all the defaults for the keyword
arguments to
None as you suggested.
3. changed how the values for things like
self.numpoints are handled
to check if they are none and look them up from
rcParams are you
suggested lines 149-159.
I don't know if there is a way to use kwargs here
instead of the
crude dictionary I set up in this part, but it works.
Let me know if
there is a cleaner way.
4. changed line 161 to check self.isaxes instead of
isaxes, because
isaxes now defaults to None:
if self.isaxes: # parent is an Axes
One thing I don't seem to be able to do is make the diff pick up the
matplotlibrc changes. The following lines need to be added to make
this feature useful:
### Legend
legend.isaxes=09:=09True
legend.numpoints =09:=094 # the number of points in the legend line
legend.fontsize : 14
legend.pad =09:=090.2 # the fractional whitespace inside the legend border
legend.markerscale =09:=091.0 # the relative size of legend markers vs. =
original
# the following dimensions are in axes coords
legend.labelsep =09:=090.010 # the vertical space between the legend entrie=
s
legend.handlelen =09:=090.05 # the length of the legend lines
legend.handletextsep =09:=090.02 # the space between the legend line and le=
gend text
legend.axespad =09:=090.02 # the border between the axes and legend e=
dge
legend.shadow=09:=09False
Let me know what to do from here.
If it matters, I created the diff from inside the directory
cvs/matplotlib on my computer (I don't know if the default would be
one level up from that for most people or not).
Ryan

John Hunter wrote:
>>>>>>"Ryan" == Ryan Krauss <rya...@gm...> writes:
> 
> 
> Ryan> Part of the problem is that I don't have much experience
> Ryan> with cvs/svn beyond checking code out. That is why I am
> Ryan> asking for a procedure. I also don't know if someone needs
> Ryan> to look at what I have done and make sure I am not a total
> Ryan> hack (I made some changes to it based on John's feedback).
> Ryan> I will in no way be offended if someone wants to look over
> Ryan> my shoulder, and I don't mind tweaking it to follow better
> Ryan> coding practices or whatever, but I do want to follow it
> Ryan> through to getting it included.
> 
> The best way is to get a copy of cvs and build your patch with 'cvs
> diff' and then post it here and on the sourceforge patches site.
> 
> And remind us after a week if we fail to take action!
In addition to John's comments, you may want to browse the ipython page on 
this topic (John, feel free to steal it and tweak it to suit your personal taste):
http://projects.scipy.org/ipython/ipython/wiki/DeveloperGuidelines
While some things there may be specific to IPython (I am _much_ more picky 
about detailed changelogs than matplotlib is, for example), the bulk of it is 
generic advice, good for anyone coming to an Open Source Python project.
About the only thing I'd add for mpl would be to make your diffs with 'cvs 
diff -u', since by default CVS doesn't do that (SVN does, so I removed that 
bit of advice yesterday). One of these days John will see the light of SVN 
and this difference will vanish :)
[ BTW, John, useful little links I found today on SVN, better than what I'd 
seen before]:
https://www.projects.dev2dev.bea.com/scdocs/ddUsingSVN_command-line
http://www.developer.com/open/article.php/10930_3499816_1
I hope this is useful.
Cheers,
f

>>>>> "Ryan" == Ryan Krauss <rya...@gm...> writes:
 Ryan> Part of the problem is that I don't have much experience
 Ryan> with cvs/svn beyond checking code out. That is why I am
 Ryan> asking for a procedure. I also don't know if someone needs
 Ryan> to look at what I have done and make sure I am not a total
 Ryan> hack (I made some changes to it based on John's feedback).
 Ryan> I will in no way be offended if someone wants to look over
 Ryan> my shoulder, and I don't mind tweaking it to follow better
 Ryan> coding practices or whatever, but I do want to follow it
 Ryan> through to getting it included.
The best way is to get a copy of cvs and build your patch with 'cvs
diff' and then post it here and on the sourceforge patches site.
And remind us after a week if we fail to take action!
JDH

This is a fairly dumb question, but is there a documented procedure
somewhere for developing and submitting patches? I had developed a
patch a few months ago to allow people to set the legend properties in
the rc file. It seems this didn't make it into the current version.=20
I recently got an email from someone wanting this feature as well, and
I told them I would follow through with it.
Part of the problem is that I don't have much experience with cvs/svn
beyond checking code out. That is why I am asking for a procedure. I
also don't know if someone needs to look at what I have done and make
sure I am not a total hack (I made some changes to it based on John's
feedback). I will in no way be offended if someone wants to look over
my shoulder, and I don't mind tweaking it to follow better coding
practices or whatever, but I do want to follow it through to getting
it included.
Thanks,
Ryan