matplotlib-devel Mailing List for matplotlib

On Mon, Jan 11, 2010 at 11:53 AM, Gökhan Sever <gok...@gm...> wrote:
>
>
> On Mon, Jan 11, 2010 at 11:09 AM, Pierre Raybaut <co...@py...>
> wrote:
>>
>> John,
>>
>> Following to your last commit on "added qt4_editor dialog" (rev 8064),
>> here is a significant (but simple) improvement adding an "Apply"
>> button to the option dialog box (very convenient) -- suggested by
>> Gökhan.
>>
>> (attached diff files should patch formlayout.py and figureoptions.py
>> as in rev. 8064)
>
> One minor update:
>
> After patching these two files, just change the 'options.svg' in
> figureoptions.py to "qt4_editor_options.svg" to suppress the icon not found
> error message.
Hey Gökhan, if you could just create an "svn diff" with the original
patches applied and your changes it will be easiest for me to apply
that way.
JDH

Good point. Fixed in r8076.
Cheers,
Mike
tcb wrote:
> Hi Mike,
>
> Sorry the long delay in replying to your mail.
>
> The changes look good, and it seems to produce good output.
>
> There is just one small change I would make- since the markers are not 
> quite properly centered on the points:
>
> Index: lib/matplotlib/lines.py
> ===================================================================
> --- lib/matplotlib/lines.py (revision 8075)
> +++ lib/matplotlib/lines.py (working copy)
> @@ -898,7 +898,7 @@
> height = ymax - ymin
> max_dim = max(width, height)
> path_trans = Affine2D() \
> - .translate(0.5 * -width, 0.5 * -height) \
> + .translate(-xmin+0.5 * -width, -ymin+0.5 * -height)\
> .scale((renderer.points_to_pixels(self.get_markersize()) 
> / max_dim))
>
>
>
> On Tue, Dec 22, 2009 at 4:44 PM, Michael Droettboom <md...@st... 
> <mailto:md...@st...>> wrote:
>
> It's been a while -- just curious if you've had any more thoughts
> on this. I'm considering committing your changes + my
> suggestions, since what's there is working pretty well.
>
> Mike
>
> tcb wrote:
>
>
>
> On Mon, Nov 2, 2009 at 3:47 PM, Michael Droettboom
> <md...@st... <mailto:md...@st...>
> <mailto:md...@st... <mailto:md...@st...>>> wrote:
>
> Thanks for all this work. It looks great.
>
> Do you mind if we bring this conversation back to the list? I
> think others may have some additional feedback, but I don't
> want
> to Cc the list without your permission.
>
>
>
>
>
> Hi Mike,
>
> sure- the discussion should go back to the list- I thought it
> might be better to get your feedback on it first.
>
> your comments are interesting, and I'll take a closer look
> later on today...
>
> tcb
>
>
> -- 
> Michael Droettboom
> Science Software Branch
> Operations and Engineering Division
> Space Telescope Science Institute
> Operated by AURA for NASA
>
>
-- 
Michael Droettboom
Science Software Branch
Operations and Engineering Division
Space Telescope Science Institute
Operated by AURA for NASA

Hi Mike,
Sorry the long delay in replying to your mail.
The changes look good, and it seems to produce good output.
There is just one small change I would make- since the markers are not quite
properly centered on the points:
Index: lib/matplotlib/lines.py
===================================================================
--- lib/matplotlib/lines.py (revision 8075)
+++ lib/matplotlib/lines.py (working copy)
@@ -898,7 +898,7 @@
 height = ymax - ymin
 max_dim = max(width, height)
 path_trans = Affine2D() \
- .translate(0.5 * -width, 0.5 * -height) \
+ .translate(-xmin+0.5 * -width, -ymin+0.5 * -height)\
 .scale((renderer.points_to_pixels(self.get_markersize()) /
max_dim))
On Tue, Dec 22, 2009 at 4:44 PM, Michael Droettboom <md...@st...> wrote:
> It's been a while -- just curious if you've had any more thoughts on this.
> I'm considering committing your changes + my suggestions, since what's
> there is working pretty well.
>
> Mike
>
> tcb wrote:
>
>
>>
>> On Mon, Nov 2, 2009 at 3:47 PM, Michael Droettboom <md...@st...<mailto:
>> md...@st...>> wrote:
>>
>> Thanks for all this work. It looks great.
>>
>> Do you mind if we bring this conversation back to the list? I
>> think others may have some additional feedback, but I don't want
>> to Cc the list without your permission.
>>
>>
>>
>>
>>
>> Hi Mike,
>>
>> sure- the discussion should go back to the list- I thought it might be
>> better to get your feedback on it first.
>>
>> your comments are interesting, and I'll take a closer look later on
>> today...
>>
>> tcb
>>
>
> --
> Michael Droettboom
> Science Software Branch
> Operations and Engineering Division
> Space Telescope Science Institute
> Operated by AURA for NASA
>
>

On Mon, Jan 11, 2010 at 11:09 AM, Pierre Raybaut <co...@py...>wrote:
> John,
>
> Following to your last commit on "added qt4_editor dialog" (rev 8064),
> here is a significant (but simple) improvement adding an "Apply"
> button to the option dialog box (very convenient) -- suggested by
> Gökhan.
>
> (attached diff files should patch formlayout.py and figureoptions.py
> as in rev. 8064)
>
One minor update:
After patching these two files, just change the 'options.svg' in
figureoptions.py to "qt4_editor_options.svg" to suppress the icon not found
error message.
>
> Thanks,
> Pierre
>
> 2010年1月3日 John Hunter <jd...@gm...>:
> > On Sun, Jan 3, 2010 at 2:41 PM, Gökhan Sever <gok...@gm...>
> wrote:
> >> You seemed like forgetting to check-in the qt4_editor_options.svg,
> because I
> >> get file not found error:
> >>
> >> I[2]: Cannot open file
> >> '.../matplotlib/lib/matplotlib/mpl-data/images/qt4_editor_options.svg',
> >> because: No such file or directory
> >
> >
> > Oops, just added. Thanks for the head's up.
> >
> > JDH
> >
>
-- 
Gökhan

John,
Following to your last commit on "added qt4_editor dialog" (rev 8064),
here is a significant (but simple) improvement adding an "Apply"
button to the option dialog box (very convenient) -- suggested by
Gökhan.
(attached diff files should patch formlayout.py and figureoptions.py
as in rev. 8064)
Thanks,
Pierre
2010年1月3日 John Hunter <jd...@gm...>:
> On Sun, Jan 3, 2010 at 2:41 PM, Gökhan Sever <gok...@gm...> wrote:
>> You seemed like forgetting to check-in the qt4_editor_options.svg, because I
>> get file not found error:
>>
>> I[2]: Cannot open file
>> '.../matplotlib/lib/matplotlib/mpl-data/images/qt4_editor_options.svg',
>> because: No such file or directory
>
>
> Oops, just added. Thanks for the head's up.
>
> JDH
>