matplotlib-devel Mailing List for matplotlib

On 06/01/2012 06:21 AM, Michael Droettboom wrote:
> Ideally, the example would be both:
>
> 1) standalone under the examples tree so that it creates a gallery
> entry in the docs
It doesn't have to be a new example, it can be a modification of an 
existing example. Examples are good, but too many can become 
overwhelming. The gallery needs pruning and additional organization, as 
has been discussed before.
Eric

Ideally, the example would be both:
 1) standalone under the examples tree so that it creates a gallery 
entry in the docs
 2) a regression test so that testing will ensure the feature 
continues to work over time
This isn't true of every PR, obviously, but for things that create nice 
new visible features it's a good rule of thumb.
Mike
On 06/01/2012 11:55 AM, Paul Hobson wrote:
> Question about this:
>
> Do you want the example in the docstring of the function or just a
> standalone script that you can run to verify that the PR actually
> works?
> (My PR will have to wait until tonight, unfortunately)
> -paul
>
> On Fri, Jun 1, 2012 at 8:37 AM, Michael Droettboom<md...@st...> wrote:
>> As you probably know, we've got a lot of pull requests in the hopper.
>> Thanks to everyone who's been triaging these lately.
>>
>> I've just gone through and tried to add comments about what's left to be
>> done with each to make them mergeable. (9 times out of 10, I'm saying
>> "add an example and unit test" ;) If you submitted a PR that you feel
>> is being ignored, feel free to ping those involved by adding a comment
>> to the end of the PR that summarizes what issues are remaining.
>>
>> Mike
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Matplotlib-devel mailing list
>> Mat...@li...
>> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel

As you probably know, we've got a lot of pull requests in the hopper. 
Thanks to everyone who's been triaging these lately.
I've just gone through and tried to add comments about what's left to be 
done with each to make them mergeable. (9 times out of 10, I'm saying 
"add an example and unit test" ;) If you submitted a PR that you feel 
is being ignored, feel free to ping those involved by adding a comment 
to the end of the PR that summarizes what issues are remaining.
Mike

Just wanted to draw attention to some platform-specific pull requests 
that need some third-party testing and comments from people on OS-X and 
MS-Windows. If you're running on one of those platforms and able to 
build from git branches, it would be great to have some input:
OS-X:
Updates to the build script:
https://github.com/matplotlib/matplotlib/pull/899
Adding an icon for Tkinter, Gtk, Wx:
https://github.com/matplotlib/matplotlib/pull/897 
<https://github.com/matplotlib/matplotlib/pull/899>
Getting the filename from the window title:
https://github.com/matplotlib/matplotlib/pull/908
MS-Windows:
Adding an icon for Tkinter, Gtk, Wx:
https://github.com/matplotlib/matplotlib/pull/897 
<https://github.com/matplotlib/matplotlib/pull/899>
Getting the filename from the window title:
https://github.com/matplotlib/matplotlib/pull/908
Mike

Welcome aboard, Phil!
Regards,
-JJ
On Thu, May 31, 2012 at 8:55 PM, John Hunter <jd...@gm...> wrote:
> Phil Elson has been making pull requests for some time now on matters
> great and small, from hairy transformations improvements to minor
> docstring cleanups to GUI fixes. Given his prolific work, I thought
> it would be suitable to recognize him as a core matplotlib developer
> by adding him to the github organization. While the distributed
> nature of the github system blurs the line between official and
> regular developers, it is helpful to recognize those who make frequent
> quality contributions and give them the permissions to merge pull
> requests into the main repo.
>
> Thanks for all your help Phil, and welcome aboard.
>
> JDH
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Matplotlib-devel mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel