openstack/swift - swift - OpenDev: Free Software Needs Free Tools

This commit updates the Swift Bandit file to the new style
introduced in Bandit 1.0. In response to the struggle with
getting a Bandit config file working and kept up to date we
introduced a simplified version in Bandit 1.0.
This commit updates Swift's bandit.yaml to use the new version.
Change-Id: Ida5dd08f4ea72a377346f2159caeb2f3741d4980

In RFC 7233, response body size of range requests with parameter
'bytes=N-M' is (M - N + 1). And response of object GET request with
range parameter in current Swift implementation is according to the
RFC. However, in current api reference explains that response body
size of object GET request with 'Range: bytes=10-15' is five
( != 15 - 10 + 1).
This patch fixes the api reference explanation.
Change-Id: I8371864f8e5adb42c1e56b7ea26c556ea1252728

There are two lines in which lists are sorted in test_reconciler.py
However, the values in the lists will be same, then the two lines are
meaningless.
This patch removes the two lines from test_reconciler.py
Change-Id: I7d72a7a4e9a27d87cd78c96f79d1b340b2ad23de

Add a note to the docstring that it is required to add a config section
to the proxy-server.conf and an entry to the pipeline to support history
mode.
Closes-Bug: 1619261
Change-Id: I888485ab4ece6f47db081a4d58c1aab24ce72a8a

When a client fully reads the content and closes the iterator, the
Client disconnected warning is still generated, as there is no logic
to check whether the GeneratorExit exception was raised after the
client received all of the data. This can be observed when doing
large object reads or using an InternalClient and reading exactly
Content-Length bytes from the returned app_iter body.
The patch amends the behavior to hoist how many bytes client read from
a given part and only raise an exception if there are more parts left
or a part was not fully read.
Lastly, the GeneratorExit exception is no longer swallowed and is
re-raised in the handling code.
Change-Id: I879149897fdb25aae977b7f17e580610b188ce04

When an exception was caught and rethrown, it should call 'raise'
without any arguments because it shows the place where an exception
occured initially instead of place where the exception re-raised.
Change-Id: I783a2a65f3e38a23ba49b6ae5a2f56a5fdaac2fc

Make sure to close the underlying iterator in string_along. What is
currently happening when using the InternalClient is that "Client
disconnected" warnings are generated and resources are tied up until
GC runs.
Change-Id: If1f6c0c756aee95f53f99371439533a97d347eab

Improve test_get_process_values_* methods in obj/test_expirer in the
form assertRaises(ValueError, x.get_process_values,{}/vals), to use
the assertRaises context form. This improves understandability by
validateing the error strings in addition to the ValueError.
Related-Change: I3d12b79470d122b2114f9ee486b15d381f290f95
Change-Id: I1c66b8894cba8328d19cf99491a8ad18ded71078

There is a white space between print and ()
in /tempauth.py, This patch fix it
Change-Id: Id3493bdef12223aa3a2bffc200db8710f5949101

They use a bare assertRaises(ValueError, ring.RingBuilder, *,*,*), but
it's not clear which one raises which ValueError(), so I extend them to
validate the error strings as well.
Change-Id: I63280a9fc47ff678fe143e635046a0b402fd4506

This is to remove unnecessary tearDown to keep code clean.
Change-Id: Ie70e40d6b55f379b0cc9bc372a35705462cade8b

Currently a versioned write PUT uses a pre-authed request to move
it into the versioned container before checking whether the
user is authorised. This can lead to some interesting behaviour
whereby a user can select a versioned object path that it does not
have access to, request a put on that versioned object, and this
request will execute the copy part of the request before it fails
due to lack of permissions.
This patch changes the behaviour to be the same as versioned DELETE
where the request is authorised before anything is moved.
Change-Id: Ia8b92251718d10b1eb44a456f28d3d2569a30003
Closes-Bug: #1562175 

Change-Id: If2cd059719fe5af1e73ecde5306e9f68d590831f

This is a follow up from a change that improved the error message.
Related-Change: I3d12b79470d122b2114f9ee486b15d381f290f95
Change-Id: I093801f3516a60b298c13e2aa026c11c68a63792

I fix error information in raise ValueError(...)
For example:
 if a>=b:
 # It should be under below and not 'a must be less than or equal to b'
 raise ValueError('a must be less than b')
Change-Id: I3d12b79470d122b2114f9ee486b15d381f290f95

This change improves the readability of the object-server's unit
tests by breaking down some long assertTrue statements into smaller
and much easier to read and more relevant assert statements.
For example:
 assertTrue(a in resp.headers and
 b in resp.headers and
 c not in resp.headers)
Is equal to:
 assertIn(a, resp.headers)
 assertIn(b, resp.headers)
 assertNotIn(c, resp.headers)
Change-Id: Iba746ecfb1a1dc541856b7a4c9d2f00d08e4ad51

Change-Id: Ib87f4df8f741809840e92db9bacf2af847a5f77f
Closes-Bug: #1600403 

Use tox substitution to avoid duplicating testenv:py34 commands in
testenv:py35, to not have to maintain the whitelist of Python 3 tests
in two different places.
Write also the list of tests in a newline to be able to more easily
add new unit tests.
Change-Id: I6e7f238f1c5d3fc9b6560918dcbb93e9dd8ec084

Change-Id: Ib4aa4a26814273efafa3453237d18acf8cc966cb

Based on comments from patch #238799.
Change-Id: I9455cf6dc7fd12fee62439ff3c5f3255287ab1be

In the past, a POST to a DLO manifest file when object_post_as_copy
was true resulted in the manifest file contents being replaced
by the concatenation of the DLO segments. This no longer
happens, but tests for this case are missing.
This patch adds a functional test to assert that the manifest
file is preserved in a POST request.
Change-Id: I90546014a7dcc7266f0d0e0ff6339688b7954b96
Related-bug: #1487791
Related-bug: #1514317