Made tests use a JSON parser in liue of eval.

Code Issues Proposed changes

The results that are being parsed are really JSON, so using a JSON parser is
more semantically correct; in addition using eval anywhere can set a bad
example.
Change-Id: Idcd55400b2571aba0f2f377cf66a3cbf4d3af960

This commit is contained in:

Alex Gaynor

2013年05月28日 07:22:42 -07:00

parent 1b283d47cd

commit b147c9e221

1 changed files with 4 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

8
test/unit/container/test_server.py

View File

@@ -722,7 +722,7 @@ class TestContainerController(unittest.TestCase):

environ={'REQUEST_METHOD': 'GET'})

resp = self.controller.GET(req)

self.assertEquals(resp.status_int, 200)

self.assertEquals(eval(resp.body), [])

self.assertEquals(simplejson.loads(resp.body), [])

# fill the container

for i in range(3):

req = Request.blank('/sda1/p/a/jsonc/%s' % i, environ={

@@ -754,7 +754,7 @@ class TestContainerController(unittest.TestCase):

environ={'REQUEST_METHOD': 'GET'})

resp = self.controller.GET(req)

self.assertEquals(resp.content_type, 'application/json')

self.assertEquals(eval(resp.body), json_body)

self.assertEquals(simplejson.loads(resp.body), json_body)

self.assertEquals(resp.charset, 'utf-8')

resp = self.controller.HEAD(req)

@@ -766,7 +766,7 @@ class TestContainerController(unittest.TestCase):

environ={'REQUEST_METHOD': 'GET'})

req.accept = accept

resp = self.controller.GET(req)

self.assertEquals(eval(resp.body), json_body,

self.assertEquals(simplejson.loads(resp.body), json_body,

'Invalid body for Accept: %s' % accept)

self.assertEquals(resp.content_type, 'application/json',

'Invalid content_type for Accept: %s' % accept)

@@ -871,7 +871,7 @@ class TestContainerController(unittest.TestCase):

environ={'REQUEST_METHOD': 'GET'})

resp = self.controller.GET(req)

self.assertEquals(resp.content_type, 'application/json')

self.assertEquals(eval(resp.body), json_body)

self.assertEquals(simplejson.loads(resp.body), json_body)

self.assertEquals(resp.charset, 'utf-8')

def test_GET_xml(self):

Made tests use a JSON parser in liue of eval.

8 test/unit/container/test_server.py Unescape Escape View File

8
test/unit/container/test_server.py

View File