Fix unsuitable assertTrue

Code Issues Proposed changes

assertTrue accepts a parameter msg which will be printed when
assertion fails, usually msg is a str. This patch fixes unsuitable
usage of assertTrue which set msg to bool type True.
Change-Id: I731f8ea553c935eba0e112ffded16f41a5ea86c0
Fixes-Bug: #1226374

This commit is contained in:

ZhiQiang Fan

2013年09月20日 23:34:06 +08:00

parent ddcf26c729

commit 92ae497800

1 changed files with 2 additions and 2 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

4
test/unit/common/test_utils.py

View File

@@ -1617,14 +1617,14 @@ class TestFileLikeIter(unittest.TestCase):

iter_file = utils.FileLikeIter('abcdef')

self.assertEquals(iter_file.next(), 'a')

iter_file.close()

self.assertTrue(iter_file.closed, True)

self.assertTrue(iter_file.closed)

self.assertRaises(ValueError, iter_file.next)

self.assertRaises(ValueError, iter_file.read)

self.assertRaises(ValueError, iter_file.readline)

self.assertRaises(ValueError, iter_file.readlines)

# Just make sure repeated close calls don't raise an Exception

iter_file.close()

self.assertTrue(iter_file.closed, True)

self.assertTrue(iter_file.closed)

class TestStatsdLogging(unittest.TestCase):

Fix unsuitable assertTrue

4 test/unit/common/test_utils.py Unescape Escape View File

4
test/unit/common/test_utils.py

View File