Make FakeSwiftCall.DUMMY_VALUE a bespoke singleton

Code Issues Proposed changes

In test assertion failure messages the DUMMY_VALUE would be shown as
<object object ...> which is not immediately recognisable as the dummy
value..
This change makes the DUMMY_VALUE show as
<test.unit.common.middleware.helpers.FakeSwiftDummyValue object ...>.
Change-Id: I73fac245c65c48d45e4919c6f15688d482148407
Related-Change: I332ce724aa10287800cbec8ca21aacc3bbd3c22a

This commit is contained in:

Alistair Coles

2025年03月07日 12:29:28 +00:00

parent 0cdd3915c4

commit 2f74376e7e

1 changed files with 11 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

12
test/unit/common/middleware/helpers.py

View File

@@ -51,11 +51,21 @@ class LeakTrackingIter(object):

self.mark_closed(self.key)

class FakeSwiftDummyValue:

_instance = None

@classmethod

def singleton(cls):

if not cls._instance:

cls._instance = FakeSwiftDummyValue()

return cls._instance

class FakeSwiftCall(object):

"""

Encapsulate properties of a request captured by FakeSwift.

"""

DUMMY_VALUE = object()

DUMMY_VALUE = FakeSwiftDummyValue.singleton()

def __init__(self, req):

self.req = req

Make FakeSwiftCall.DUMMY_VALUE a bespoke singleton

12 test/unit/common/middleware/helpers.py Unescape Escape View File

12
test/unit/common/middleware/helpers.py

View File