openstack/openstack-ansible-os_trove - openstack-ansible-os_trove - OpenDev: Free Software Needs Free Tools

Change-Id: I4a2696cd2727658fadbe56f172b54e70db57aa6b

The variables trove_developer_mode and trove_venv_download
no longer carry any meaning. This review changes trove to
do the equivalent of what developer_mode was all the time,
meaning that it always builds the venv and never requires
the repo server, but it will use a repo server when available.
As part of this, we move the source build out of its own file
because it's now a single task to include the venv build role.
This is just to make it easier to follow the code.
Change-Id: I08c864eaef894074326d765bb424fa6b98ec0ed2

Change-Id: Id1c0789e1d69bebcb37d0b0e68a230be82c9f669

Change-Id: I6cd1972e87ad0e51d3dc923e3dc5c87f9bf5db1e

The private option on include role was never implemented and
will no longer be developed. This change removes the option
so ansible no longer raises a deprecation warning.
Change-Id: Ia682b9fdeef6d29546c5996bd7bf2978ae6f0ef3
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>

The notification driver setup was resulting in the driver and connection string
on the same line. This is caused by the case statement and how jinja formats
the template when a case statement is present. This change modifies how the
driver string is created using a ternary, which will eliminate the case
statement and render the value of the diver correctly.
Change-Id: Iefcec440db0e61adf8c6ce3a8b8ae9a4125a802d
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>

Secure by default
Change-Id: I71d4ba27c1cd3509fd99dbad0e7e7ff206f723f7

Needed if trove service network is vlan or vxlan or gre
If flat, this option is omit
Change-Id: Ic28a6802ad00178cbabb7303c22e16fcf3a4f83a

openstack-dev was decomissioned this night in https://review.openstack.org/621258
Update openstack-dev to openstack-discuss
Change-Id: I2f2bd51c4f3fe1efe9e5bdc15ba48c21d3507e9a

In order to enable the service setup host python interpreter to
be changed easily, we make it a variable. This will be useful
when someone sets the service setup host to be the utility
container, because we'll be able to set this var by default.
Change-Id: I2a4b1b82307b3dd195bff8f9a8fb219ad581c2ad

The connection plugin no longer falls back on using the
inventory_hostname as the container_name. Set container_name as a host
var for each container in the test inventory.
Change-Id: Ie39f2ef9c2f481479e6b73e88b6a7f27d8df8aea

Without this patch, the release notes published at
https://docs.openstack.org/releasenotes/openstack-ansible/rocky.html contains
the same line multiple times which is not very clear.
[...]
 Support separate oslo.messaging services for RPC and Notifications
 to enable operation of separate and different messaging backend servers.
 Support separate oslo.messaging services for RPC and Notifications
 to enable operation of separate and different messaging backend servers.
[...]
Change-Id: I0ed1a43670d97f2e2215d04c641f7bd4cfbe4f44

Change-Id: Ia5a508fda4ba879c18fc7e6d648cbc6c76cbb885

Change-Id: I36a99e54b8eecad13366ae6e76a9c5dc42264fc1

Change-Id: I26e7a2e27f526776f8b4c4d567cf792ee310161c

Change-Id: I8ef587f964c555aa8ce870ce0f26ac20b335e34e

This patch add the conditional inclusion of the notification
section of the service configuration. This ensures that oslo.messaging
notifications use the correct transport for deployments that have
separate rpc and notify messaging backends. For example, if the
transport_url is not provided in the notification section of the
service configuration, the transport_url specified in the default
section will be used instead.
This patch conditionally selects the notifier driver. The noop
driver will be selected when notification publishing is disabled.
The messagingv2 driver is selected when notification publishing is
enabled.
Change-Id: Ie967b281e15127bbf611aca557e99ac6b3d1cd4b
Closes-Bug: #1794320 

We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I1e3aebc5542bea5cab66aaa2f295099b88928eb1
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Given that pymysql is pure python and has no C binding
dependencies, we no longer need the role to install the
MariaDB client libraries.
Change-Id: I78d209a4c35379ede7f98019edc1250903a87895

The SUSE builds are failing due to a change in the galera_client
role causing the trove role's vars file to be found before the
galera_client vars file. We therefore rename the trove vars file
for SUSE. This also makes transitions between versions easier.
The mysql-python package is no longer maintained. We are using
pymysql instead, so this package does not need to be installed.
This resolves current build failures due to the mysql-python
package not being installable due to the new version of MariaDB
being used.
Depends-On: https://review.openstack.org/602924
Change-Id: Iaee84e8cec7c19d306924adf3743e03da6fa6b4f

Curly quotes(Chinese punctuation) usually input from Chinese input
method. When read from english context, it makes some confusion.
Change-Id: I718a3364c8398545e46df0da39de4f94330c2da7
Closes-Bug: #1792131 

Now that we're using the general templates, we can slim down
the role test definitions. We can also remove tests which are
not being watched, or which are fundamentally broken. With
this we can also remove unused scripts/plays.
We do the following:
1. We remove the 'ssl' job, given that the person working on
 that is no longer doing so, and no-one else has picked up
 the work.
Change-Id: I2c7c0e1e682e24f15270d4c81b62dc927a766a3f

include is marked as deprecated since ansible 2.4[0]
Switch to include_tasks or import_playbook as necessary
[0] https://docs.ansible.com/ansible/2.4/include_module.html#deprecated
Change-Id: I2351c93c2ce5beb44404dc05b487f40e14973810

The yaml should start with "---"
Change-Id: I30a278eb546bc5da2ba005c431d703f17d1e71ba

In order to radically simplify how we prepare the service
venvs, we use a common role to do the wheel builds and the
venv preparation. This makes the process far simpler to
understand, because the role does its own building and
installing. It also reduces the code maintenance burden,
because instead of duplicating the build processes in the
repo_build role and the service role - we only have it all
done in a single place.
We also change the role venv tag var to use the integrated
build's common venv tag so that we can remove the role's
venv tag in group_vars in the integrated build. This reduces
memory consumption and also reduces the duplication.
This is by no means the final stop in the simplification
process, but it is a step forward. The will be work to follow
which:
1. Replaces 'developer mode' with an equivalent mechanism
 that uses the common role and is simpler to understand.
 We will also simplify the provisioning of pip install
 arguments when doing this.
Depends-On: https://review.openstack.org/598957
Change-Id: Iaff49b75b03635fb07260c9a96f6459d270aed83
Implements: blueprint python-build-install-simplification
Signed-off-by: Jesse Pretorius <jesse.pretorius@rackspace.co.uk>

This is a mechanically generated patch to switch the documentation
jobs to use the new PTI versions of the jobs as part of the
python3-first goal.
See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html
Change-Id: I87dbe72efad93f7358add21386c2229008f0e2dc
Story: #2002586
Task: #24319 

doc8 is now run as part of the new docs build job, fix failure.
Merge duplicated section.
Remove html_static_path, this is non-existant.
Fix docs environment to enable warnings.
Change-Id: I47b0af6257c0bc96fd23a5bd8620a6e137c77f17

We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I0755516a64149f75165ca33fbd6db0a2222027d6

This is a mechanically generated patch to complete step 1 of moving
the zuul job settings out of project-config and into each project
repository.
Because there will be a separate patch on each branch, the branch
specifiers for branch-specific jobs have been removed.
Because this patch is generated by a script, there may be some
cosmetic changes to the layout of the YAML file(s) as the contents are
normalized.
See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html
Change-Id: I63e0d9240c35b1075e27aa820c9eaf22792531f4
Story: #2002586
Task: #24319 

Change-Id: Id584ab056bf23db6459aa4c6f6b12f7e853c6c8a

Change-Id: I373aec0522117508a94792145c43d450f41880d7

The TESTING_BRANCH environment variable is provided by the
run_tests.sh script and is derived from the .gitreview file.
This ensures that once the master branch becomes a stable
branch, the constraints from the stable branch in the
integrated repository will automatically get used once the
.gitreview file is updated.
To ensure that the required environment variables are present
we export them appropriately in run_tests.sh and modify the
tox configuration to pass them into the tox test.
Change-Id: Iae1951ba7a7d30fc8913ac0b654a789288a98b58
Needed-By: https://review.openstack.org/579371 

The trove tempest plugins were re-organised in
https://review.openstack.org/587489 so we now
need to use the new structure.
Change-Id: I903c46be39636e3922d077f9007ac8f847d02684

Change-Id: I2a04fd6851d0e87fe94ef5c64fc601b411097905

The use of 'include_tasks' and a loop of variables creates
a situation where a user is unable to use tags to scope the
inclusion of only the MQ tasks when running the playbooks.
The use-case this is important for is when the rabbitmq
containers are destroyed and rebuilt in order to resolve
an issue with them, and the user wishes to quickly recreate
all the vhosts/users.
Ansible's 'include_tasks' is a dynamic inclusion, and dynamic
inclusions are not included when using tags. The nice thing
about dynamic inclusions is that they completely skip all
tasks when the condition does not apply, cutting down deploy
time. However, given the use-case, we should rather take on
the extra deployment time.
This patch changes the dynamic inclusion to a static one,
adds a 'common-mq' tag to cover all MQ implementations,
and re-implements the 'common-rabbitmq' tag for the tasks
that relate to RabbitMQ specifically.
It also implements conditionals for each task set so that
the rpc/notify tasks can be skipped if a vhost/user is not
required for that purpose (eg: swift does not use RPC, and
most roles will not use notifications by default).
Depends-On: https://review.openstack.org/588191
Change-Id: I320ae83839869ee89fa5db3bf5c55d245f3b17db

Change-Id: I9c5eef75f60414a98dd395b117a95751b31cb225