openstack/openstack-ansible-os_nova - openstack-ansible-os_nova - OpenDev: Free Software Needs Free Tools

This patch resolves the following:
- Removing the default var declaration of glance_api_servers
 and declaring it within the functional test vars since the
 role does require the variable be defined.
- Fix absence of neutron_openvswitch_agent due to
 https://review.openstack.org/338129
- Adjust the use of rabbitmq vars to ensure that they're
 properly namespaced. https://review.openstack.org/339810
Co-Authored-By: Jean-Philippe Evrard <jean-philippe.evrard@rackspace.co.uk>
Depends-On: Ibc0a5b70d4da2e905b10b4c1334b57a6f0f3b4ed
Change-Id: If33d3ce9e9dfee827a92c9c0813b7c0a18cb8a7b
Partial-Bug: #1596084 

Add pip_install_options to test vars to ensure libvirt-python is built
from source. A pre-built wheel can be missing libvirt capabilities
from the installed version of libvirt-bin, leading to nova-compute
failing to start.
neutron_rabbitmq_* test variables have also been included as they are
required for the neutron install to complete.
Change-Id: I57e9c50bf835db1ffda2507764a09cb74d7c0884

This patch updates the sphinx configuration for docs and releasenotes
to make it easier to replicate across repositories and to comply with
pep8 testing without exceptions.
Change-Id: Ida2a6c468bbf379f937296aa73c95e25be0b4da6

Currently, non-encrypted SASL-authenticated communication (qemu+tcp
protocol) is the default for connecting to libvirtd in remote compute
nodes during live migration. This commit changes the scheme to encrypted
SSH-authenticated communication, which is readily usable since the role
already distributes SSH keypairs between the nodes.
Change-Id: Ia6d2c99872e192ab308fc6d0195b609c95f55ff5
Closes-Bug: #1580276 

Filter libvirt in nova.conf. Create nova_powervm symbolic link to
nova.virt.nova_powervm module.
Change-Id: I479ff18d15097738eb6671d3cdbe66e6ef66cd31

Switch from quoted string to actual octal number format
Change-Id: Ie188dc7cab2072a94395732c002443d10fcb1cae

Change-Id: I5912e586c9d620369e84b8d1811d46dfa1677047

* The default apt packages have been moved the appropriate
 platform specific vars files.
* Most apt related tasks have been moved into the common
 nova_install_apt task file which is only executed when
 apt is the package manager.
* Vars with 'apt' in the name have been changed to be more
 generic.
Implements: blueprint multi-platform-host
Change-Id: Ie97c0379b18a9ecabf3e4c0148cb555771b04747

As discussed during the Newton design summit, we
agreed to adopt the role documentation pattern laid
out in the os_keystone role
Change-Id: I36d2b0c99472b470d11cac20854513c3d8b40b78

They serve no purpose and were incorrect in at least
one location.
Removing them should slightly improve the readability
and maintainability of the functional tests.
Change-Id: Ia19af44702c90268f6546d485eef59449ea222ce

os_nova now supports Ubuntu 16.04, aka xenial.
This commit adds the missing platform version xenial to
the role meta data.
Change-Id: I49e797e65e7a5a4a11ec451680c488bac679378d

network_api_class config has been deprecated in favor of
use_neutron
Prior to this change, the nova-compute.log would complain with:
"Config mismatch. The network_api_class specifies
nova.network.neutronv2.api.API, however use_neutron is not set to True. Using
Neutron networking for now, however please set use_neutron to True in your
configuration as network_api_class is deprecated and will be removed."
Change-Id: I2933565deec42172c9cdc836c5a4b88b44214d07

This patch cleans up the container cache preparation in the tests
due to the following patches:
- https://review.openstack.org/307856 (new image build process)
- https://review.openstack.org/315114 (new apt config process)
- https://review.openstack.org/322188 (new resolver config process)
Change-Id: I9eb6218d3b238eeaafce736024f195d8a494efc7

In https://review.openstack.org/320624 a method of providing the
shell module arguments was used which breaks ansible-lint (and
is improper anyway). The lint check did not effectively catch
this. The lint check not working will be resolved in another
patch. This patch fixes the task's syntax to ensure that fixed
lint checks implemented in other repositories do not fail on
this role.
Change-Id: If62fed46937193c0868ca2c9d2b4c29bfd331c59

A new release of flake8 is causing lint faiures. Our requirements
should match OpenStack requirements anyway.
This patch pins to the current master requirements from the
OpenStack requirements repository using global-requirements.
Change-Id: Iaf5fffa3b3fdd4ec0bc0e8f28bb2e816b67c8729

Change-Id: I23876850fb1438a270a11db0442261b225c237cd

When executing the role with Ansible 2.1, the following
deprecation warning is issued in the output for some tasks.
[DEPRECATION WARNING]: Using bare variables is deprecated.
This patch addresses the tasks to fix the behaviour appropriately.
Change-Id: I7ef4e446d6fc509420d5b297378f4fa91a519fc8

This implements support for Ubuntu 16.04. The changes
primarily relate to implementing systemd service files
instead of upstart init scripts.
Implements: blueprint support-ubuntu-1604
Change-Id: If0d4de3519e04a45795e64fca9c8ca7b56729a88

The pip_install and pip_lock_down roles have been merged.
Remove pip_lock_down from the role's meta dependencies and test
requirements.
Change-Id: Id7803c0f6ebb9b9ccd2add64f71f6110de491db8

Add powervm playbooks to enable PowerVM platform as Openstack
compute node and also to support to configure the PowerVM NovaLink
feature (required for OpenStack integration) as well as
the PowerVM OpenStack drivers.
Change-Id: Ic6197ea8940a7958d8b422b2627e6e96fd6deb21
Partially-Implements: blueprint powervm-virt-driver

The documented variable to use to set the nova group uid is:
nova_system_group_gid. Correct the variable name in the
nova_pre_install.yml task.
Change-Id: Ia4316c00c7dacae730c0802a9119141757e1eab6
Closes-Bug: 1589663

With updated version of libvirt the default network is created but
is not enabled. Because the default has changed the virsh command
to disable the network is raising an error because the network is
already disabled. To resolve this we added "failed_when: false"
to the default network disable task.
Change-Id: I198db581db22655dc8791ba40a77a39b362c1b73
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>

This fix executes the nova virt type detection on any playbook run
and will eliminate the need to specify the nova-cpuinfo-read,
nova-virt-type-set tags along with the intended tag like nova-config.
Change-Id: Ic34011149f1355cfa48f4ee35537362e2d24e55d
Closes-Bug: #1587452 

Change-Id: I5d74d26a57793732c33f3cda249e9c0967c34146

This changes adds the Ubuntu Cloud Archive repo support for the nova
compute kvm. UCA repo is important to support architecture ppc64le
since the default Ubuntu trusty repo does not contain the all required
packages for libvirt-bin.
Change-Id: Ic1e7619b48a9b12ba876f83507497cf1e557223a

Nova can fill up the partition that /var/lib/libvirt/qemu/save is on
when nova calls `image-create` on an instance. This occurs because
nova calls libvirt with managedsave which creates a temporary file in
the /var/lib/libvirt/qemu/save location. Libvirt does not allow the
location of /var/lib/libvirt/qemu/save to be configurable so we have
to manage it ourselves via bindmounts or symlinks.
In this commit we remove the /var/lib/libvirt/qemu/save directory and
create a symlink in it's place, pointing to
`{{ nova_system_home_folder }}/save` instead (which we also create).
This location was chosen as deployers often have more space here for
nova instances.
Change-Id: I5c96f70aa355cc02379fe7e0681416eca53447eb
Partial-Bug: #1585325 

Use the existing nova namespaced variables instead of overriding and
providing a generic 'service_' variable for use with the service setup
tasks. The existing nova_service_setup.yml file can be directly replaced
by nova_service_add.yml.
This also fixes a recursive loop issue seen when deploying the
integrated release with Ansible 2.1.
Change-Id: I72dc237623f2307430e219433425a6d67f15050d

The os_nova role can now detect a PowerNV environment and set the
nova_virt_type variable to 'kvm'.
Change-Id: I5900b957bcd39ce2a5fb9afd7db4d09185733157

This patch adds wget to the whitelist_externals for tox.ini.
This will prevent a minor error that occurs in the logs due to wget not
being in this list - even though it is used when getting human_log.py
Change-Id: I976bc361c0b2741a88a76a1489a7c44b03dd4a47

This fix removes /usr/share/spice-html5 and /usr/share/novnc
before updating it in order to prevent git clone issues where
simple git resets seem not clean enough.
Change-Id: I8abdffc2377b68fc40a6a9b678f24eb99a0bc537
Closes-Bug: #1585331 

Changes metadata_host to a var, which defaults to "internal_lb_vip" but
can be changed.
This allows you to set a metadata_host that is not the internal_lb_vip.
Change-Id: Ic1c9d40aedb24596fe2a24f236c49a79028102b8

The 'Create authorized keys file from host vars' task assumes that every
host within the nova_compute group is available. If any host within that
group is offline, excluded through a limit, or has otherwise failed an
earlier task, it will lead to this task failing for every host.
Add a when clause checking for the existence of the nova_pubkey hostvar
so that the task and remainder of the role can continue when a
nova_compute host is unavailable.
Related-Bug: 1531783
Change-Id: Idec01d13c35632204a2ae0f0a848a0ccc5b34d73

Review [1] handles symlinking of python Ceph libraries outside of venv.
This commit simply removes installing python-cephlibs.
[1] https://review.openstack.org/#/c/317901/
Change-Id: I5f88fc59da8b634849d01fbea005be7f50dcf0be
Depends-On: Iac3b04eec57f6d1aa21051f2960d56e3b47b6f00

The db create tasks have been removed from the role and have been
relocated into the playbooks.
Change-Id: I8b9761689f3c6c51a3a7b50e71c8acf040a6c32f
Depends-On: If58e482034a65c0e50241448dbe298a73c1ae71b
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>