Refactor use of include_vars

Code Issues Proposed changes

Use a first_found lookup instead of a with_first_found loop so that
the 'paths' parameter can be used.
This ensures that only vars from the role are included, and not vars
from a parent calling role. This can happen when a parent role has
a higher priority vars file available for inclusion than the role
it calls.
Change-Id: I046def5a5cc94f680bc0daa3a2a1734f325d8022

This commit is contained in:

Jonathan Rosser

2022年01月12日 08:18:07 +00:00

parent 7a33271509

commit 1c353392c3

1 changed files with 12 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

20
tasks/main.yml

View File

@@ -14,14 +14,18 @@

# limitations under the License.

- name:Gather variables for each operating system

include_vars:"{{ item }}"

with_first_found:

- "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml"

- "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml"

- "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml"

- "{{ ansible_facts['distribution'] | lower }}.yml"

- "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml"

- "{{ ansible_facts['os_family'] | lower }}.yml"

include_vars:"{{ lookup('first_found', params) }}"

vars:

params:

files:

- "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_version'] | lower }}.yml"

- "{{ ansible_facts['distribution'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml"

- "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_major_version'] | lower }}.yml"

- "{{ ansible_facts['distribution'] | lower }}.yml"

- "{{ ansible_facts['os_family'] | lower }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml"

- "{{ ansible_facts['os_family'] | lower }}.yml"

paths:

- "{{ role_path }}/vars"

tags:

- always

Refactor use of include_vars

20 tasks/main.yml Unescape Escape View File

20
tasks/main.yml

View File