do not allow specs with zwsp characters

Code Issues Proposed changes

For some reason a number of specs (and docs) have zwsp characters
inserted in URLs. This causes crud in the reviews, and really
confusing errors around line lengths for people (we count them, but
they aren't seen in their editor).
This removes them and makes a test to make sure they never come back.
Change-Id: Ib6e94725e2716dbb2ff86f272fbe4a6987714444

This commit is contained in:

Sean Dague

2016年06月01日 14:42:38 -04:00

parent ed3fa63282

commit 4ed51d077e

7 changed files with 14 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

2
specs/liberty/approved/user-data-modification.rst

View File

@@ -51,7 +51,7 @@ REST API impact

The method:

"/v2/{tenant_id}/servers/{server_id}"

With the method type PUT.

2
specs/liberty/implemented/show-reserved-status-in-os-fixed-ips-api.rst

View File

@@ -75,7 +75,7 @@ minimum supported version.

* 404: If the address on the request does not match a FixedIP entry in the

database.

* ``/v2.1/{tenant_id}/os-fixed-ips/{fixed_ip}``

* Parameters which can be passed via the url: The fixed IP address

2
specs/mitaka/approved/nova-api-hypervsor-cpu-info.rst

View File

@@ -99,7 +99,7 @@ REST API impact

Change in should be added in a new API microversion:

`GET /v2.1/os-hypervisors/{hypervisor_id}`

Show hypervisor details

Shows details for a specified hypervisor.

2
specs/mitaka/approved/user-data-modification.rst

View File

@@ -51,7 +51,7 @@ REST API impact

The method:

"/v2/{tenant_id}/servers/{server_id}"

With the method type PUT.

2
specs/newton/approved/console-log-offset.rst

View File

@@ -54,7 +54,7 @@ if log doesn't contain this offset response should be empty.

Request:

URL:

/v2.1/{tenant_id}/servers/{server_id}/action

Method:

2
specs/newton/approved/nova-api-hypervsor-cpu-info.rst

View File

@@ -99,7 +99,7 @@ REST API impact

Change in should be added in a new API microversion:

`GET /v2.1/os-hypervisors/{hypervisor_id}`

Show hypervisor details

Shows details for a specified hypervisor.

8
tests/test_titles.py

View File

@@ -96,6 +96,13 @@ class TestTitles(testtools.TestCase):

"Found %s literal carriage returns in file %s" %

(len(matches), tpl))

def _check_no_zwsp(self, tpl, raw):

matches = raw.decode('utf-8').find(u"\u200B")

self.assertEqual(

matches, -1,

"Found zero width space characters in file %s" %

(tpl))

def _check_trailing_spaces(self, tpl, raw):

for i, line in enumerate(raw.split("\n")):

trailing_spaces = re.findall(" +$", line)

@@ -124,4 +131,5 @@ class TestTitles(testtools.TestCase):

self._check_titles(filename, template_titles, titles)

self._check_lines_wrapping(filename, data)

self._check_no_cr(filename, data)

self._check_no_zwsp(filename, data)

self._check_trailing_spaces(filename, data)