On 17/08/2020 1:13 pm, Henk-Jaap Wagenaar wrote:
On 2020年8月17日 at 11:30, Mark Shannon <[email protected] <mailto:[email protected]>> wrote:I would also bring you attention to my rigorous analysis of the possible application to PEP 622 the entirety of CPython. If I have made any mistakes there, I'd be happy to correct them.You say "I've elided a lot of complex logic int cases, as it is not relevant." in the plistlib._BinaryPlistWriter._write_object example, this seems to be a prime example where guards could be used to simplify/unnest the logic? Even if you disagree, I think it is highly relevant and worth commenting on, one way or another!
Thanks for the feedback.I've expanded the code in the `int` and `UID` cases, and made it clearer why the remaining code has been elided.
Cheers, Mark. _______________________________________________ Python-Dev mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/WMLES4ER52GGJCXQTH2ULSF5EESCXVHY/ Code of Conduct: http://python.org/psf/codeofconduct/