Objections to subjecting all modules to a code review process?

Events happening in the community are now at Drupal community events on www.drupal.org.
Posted by Diogenes on October 8, 2012 at 2:39pm

The peer review process is deeply flawed in that it often takes a year or more to get a module approved. A wait of 3 months for a review is typical. There are not enough people doing reviews, especially experienced module developers.

The attrition rate (people who drop out) is also unacceptably high.

see Just a Few Good Men for some numbers.

Current members who have previously contributed are not subject to any code review. If all members were subject to a code review and it was required that everyone must review another module prior to publishing a new one, the problem would be solved.

The lack of reviewers would disappear. By my estimate, there are 6-7 modules added every month from existing Full Project members for every module from a new member. The quality of the contributed modules would also improve. And the system would be fair, Currently it is not.

So what are the objections to this?

Comments

By my estimate, there are 6-7

Posted by greggles on October 8, 2012 at 10:39pm

By my estimate, there are 6-7 modules added every month from existing Full Project members for every module from a new member.

In the last 30 days the ratio is not 6 to 1, but 1 to 3 (148 full projects to 472 sandbox projects).

mysql> select count(1), sandbox from project_projects p inner join node n on p.nid = n.nid where n.created > (unix_timestamp() - 606024*30) group by sandbox;
+----------+---------+
| count(1) | sandbox |
+----------+---------+
| 148 | 0 |
| 472 | 1 |
+----------+---------+

I appreciate that this process can be painful and I appreciate that it has upset you. A lot of people have worked on this previously and your proposals would be improved by reviewing their research and proposals.

It must be nice

Posted by Diogenes on October 9, 2012 at 5:52am

Sigh. It must be nice to be able to just run a query like that. I had to use the drupal.org website. It can be slow. But not as slow as the groups.drupal.org site.

This is my second attempt to respond here. The first went to that big bit bucket in the sky. It might have been the markup I tried. I have a local copy saved now, now just in case. No markup this time.

Perhaps Klausi's rewards program for doing code reviews is working. The numbers look encouraging. Were there really 620 new modules in the last 30 days?

And more to the point, what objections do you have to extending the code review process to everyone, not just new members?

My post was in support for what Benjamin Melançon said at the end of the Drupalcon Munich sessions.

http://sontag.ca/drupal/process-broken

Thank you for the link to the Drupalcon London session. It had an excellent panel and a lively discussion. I wish I had been there to hear all of it. They had some excellent things to say and I will be referring to it in the future.

Peer Review

Group organizers

Group categories

Project Type

Group notifications

This group offers an RSS feed. Or subscribe to these personalized, sitewide feeds:

AltStyle によって変換されたページ (->オリジナル) /