Posted by dreamleaf on May 23, 2011 at 4:37pm
While sat in the queue for my application, I thought I'd help out someone else and decided to grab a copy of their theme via Git and give it a quick once over.
Now I feel bad, as the theme @ http://drupal.org/node/1150074 appears to be a hashed copy of the Corolla theme for D7. I left a comment to that effect and suggested it would be better suited as a subtheme.
Comments
Good catch ... I doubt I
Good catch ... I doubt I would have caught on. :)
This does raise an interesting point ... to what extent is code duplication an issue when it comes to themes? I know that I've never built one from scratch - I simply find the closest theme and tweak it to my liking. Is there a precedent for this from the code-review perspective?
In this specific case, the tweaker didn't even remove the old author's name in the CVS tags; and the code IS about 90% the same ...
... In any case, don't feel bad ... I just told a 6 month old CVS appicant that they should probably just create a new application. :P
The only reason I noticed it
The only reason I noticed it is that I've literally just used Corolla for a site build, as soon as I downloaded the repo the familiarity jumped out. The issue thread does appear like a friend trying to push through a friends application, which is ok if the quality is good I guess.
Dreamleaf Media