Code review for security advisory coverage applications

Manual Reviews

Basecamp
http://drupal.org/node/1457152#comment-6503888

Hide Node Title
http://drupal.org/node/1783722#comment-6499378

CiviCRM Stripe
http://drupal.org/node/1722212#comment-6498754

TwitterCards
http://drupal.org/node/1772594#comment-6499260

Probabilistic Weight
http://drupal.org/node/1816018#comment-6651112

Simple LDAP
http://drupal.org/node/1845236#comment-6753118

Web Experience Toolkit Distribution
http://drupal.org/node/1494484#comment-7053876

klausi remembered me about the surveys we prepared for the talk at dc munich and yes, it's about time that I publish them as promised.

Also, as the "the process sucks"-discussions are on fire again some of these comments might be useful.

Here are the (anonymized) exports of webform.com:
(tried to import them on google docs it did a horrible job, I recommend you to use open/libre/whatever-office and set "tabs" as delimiter.)

Survey 1:
"Project application process"
30. Apr - 14. May
122 Submissions
http://groups.drupal.org/files/pasurvey1.csv

Survey 2:

Hi !

This page is used to keep track of cubeinspire's reviews and help in the project application queue. We will use this page as reference to his work and to help him become a code review administrator at some point. Please add any advice to you might have in the comments.

Manual reviews

Wunderground API:
http://drupal.org/node/1781984#comment-6477442

Ajax_check_email:
http://drupal.org/node/1784482#comment-6477506

Hide Nodetitle:
http://drupal.org/node/1783722#comment-6510342
http://drupal.org/node/1783722#comment-6585016

Sans Druplicon:

We have currently 27 RTBC project applications that need a final check by a code review administrator. I am quite busy with the review bonus program so I don't have time to review/approve all of them.

You can help: if you are a code review administrator it would be cool if you could checkout at least one RTBC application per week (or more, or less - any help is appreciated).

We will go through the project application issue queue and will review as many applications as we can. Anybody is welcome to join this sprint, we help new contributors and more experienced Drupalistas alike. We will have a lot of fun and we will provide a great mentoring and learning experience.

The sprint will be located at the official Drupalcon Munich sprint venue.

Here are some instructions for this sprint and what we will be doing.

I created the Twitter account @drupal_review that automtically aggregates some RSS feeds and to post news on the project application review process occasionally.

Currently the following feeds are forwarded with twitterfeed.com:

Fixed applications: http://drupal.org/project/issues/rss/projectapplications?status=2
Discussions in this group: http://groups.drupal.org/node/103499/feed

If you are a code review administrator and would like to help maintain this account just contact me.

Hi team,

I am facing problem to create the sub navigation in Drupal? Basically this navigation created under of my own module. For example like my link is example.com/?q=abc/program/123.
So if you see the attachment then u will get understand that I want to add new tab [Program 3] under of program tag. So could u tell me how to do it.

Please check the Program [Red mark] and then Program1 [green]

Thank you

Drupal core has Issue count thresholds to keep the number of outstanding bugs and tasks under control. It might be a good idea to introduce something similar for project applications. This would mean that we do not approve RTBC applications while a certain threshold is exceeded. We reach out to the other applicants and the rest of the community in such a situation to get back under the threshold(s). Getting back means reviewing applications.

I'm proposing two thresholds:

<

ul>

We've already discussed how a checklist for reviewing project applications should look like several times, but these discussions never really reached all reviewers and won't reach new applicants at all - but they should to make it easier for them to find their own failures and reviewing applications on their own.

Me and patrickd are proposing a session about the project application review process at Drupalcon Munich. Feel free to provide us with feedback what else you would like to see in this session.

Hello,

July 28th and 29th is the 2012 Drupal Camp LA. It is being held in Irvine CA. I have just gone through the project review process and am holding a panel discussion on getting vetted; SO YOU WANT TO START A PROJECT ON DRUPAL.ORG (PANEL).

Currently we have the policy that applicants can raise their application priority after 2 weeks without a response (documented in How to review Full Project applications). A review bonus is now strongly recommended in the application documentation and I think we should also adapt our application priority guidelines.

The review bonus program is a great way to encourage community interaction and to guarantee a faster response time for applicants that help others. We don't have many regular application reviewers at the moment and application approval can take a long time. I think the review bonus program is a major reason why the project application issue queue has not spun out of control completely in recent months.

There should still be some review process after one is given full git access, as there are many people who take it in wrong sense & put modules as which are not may be required.
Just some review process so that same quality which is checked while approving project applications during giving git access can also be maintained later.
Do we really require those projects which may not follow standards to be there ?
Like http://drupal.org/project/contact_profile
No offense, but is it fine to put a module with minimal code [e.g. drupal_alter just] as full project?

Again we have an issue with a group of people doing a project application: http://drupal.org/node/1211132

It seems that we user that posted the application have done none of the commits to the project, but three other users have.

I can not see how this could be a valid application at all. How could we know which of the users that do understand the basics?

Dunno how usefull it is, but it gives a nice overview:

// edit: added a shortlink
http://ventral.org/paissues

It is based on the rocketship module of Gábor Hojtsy, modified to work on the project application queue.

Being a git administrator I have decided to focus my time on project applications with a review bonus. That means that I will not look through the RTBC queue anymore, I have bookmarked the review bonus queue instead which I will use from now on.

NOTE: PLEASE FEEL FREE TO ADD AND EDIT!

What is it?

The ‘Project Application’ process is the means by which new module/theme contributors can apply to include their project on Drupal.org, and be granted the ‘Create Full Projects’ permission on the d.o site. At any given time, we have nearly 150 projects waiting in a ‘needs review’ state ... thus, we desperately need your help!

The automated PAReview tool hosted at ventral.org provides automated 'code style review' reviews for new project applications submitted into the "Full Project Approval" process, and provides both Coder and Drupal CodeSniffer review results. While this tool has revolutionized the coding style portion of project application reviews, the next logical step is to migrate it onto 'official' Drupal infrastructure, and integrate it with the automated testing infrastructure.

I see the following as the major items required to make this happen.

Hello.

Many modules have status "reviewed and tested by community" in here
http://drupal.org/project/issues/projectapplications?text=&status=14&pri..., but nobody approve their.
My module "comment abuse" is already waiting for 12 days.
Somebody can review and approve them?

Thank you.