Code review for security advisory coverage applications

This page serves a_thakur's project application reviews and help to project application reviews. This is a part of mentoring to become a code review administrator eventually.

I have been reviewing projects from last year. I would like to actively review more projects from now on and become a code review administrator eventually.

https://drupal.org/project/issues/search/projectapplications?project_iss...

Do not simply copy/paste this template. Walk through the items and update them as needed: choose from yes/no, list found issues. In general, all text within the square brackets is for the reviewer only and should be updated by the review results. To indicate particular points use these more descriptive templates.

Taking a page from https://drupal.org/issue-summaries, I've added a section to Increasing efficiency in manual code reviews that provides a template for reviewers. It is sort of a checklist for reviewers. This should help novice reviewers that working on the bonus tag and experienced reviewers with their efficiency. Feedback appreciated.

Part of my hope is that it will give reviewers more direction on what areas they should cover and in general help make reviews easier.

This page serves heddn's project application reviews and help to project application reviews. This is a part of mentoring to become a code review administrator eventually. Add any advice that you may have through comments.

I also lead a sprint for 5 people at DrupalCon Austin about this subject and was able to to provide mentorship about the process of applying for a full project.

https://drupal.org/project/issues/search/projectapplications?project_iss...

<

ol>

This page serves joshi.rohit100's project application reviews and help to project application reviews. This is a part of mentoring to become a code review administrator eventually. Add any advice that you may have through comments.

Project Application queue, current state:
- Needs Review: 83
- RTBC: 58
- Needs Work: 118

I know I haven't contributed in a while, but I'd like to go to con with an almost-clean slate. I'll do what I can to get those numbers down :) And if you're planning on being at DrupalCon, I'm sure there will be a sprint on this topic.

This page serves madhusudan's project application reviews and help to project application reviews. This is a part of mentoring to become a code review administrator eventually. Add any advice that you may have through comments.

[D7] Views Database Connector
https://drupal.org/comment/8615473#comment-8615473

[D7] Alert Message
https://drupal.org/comment/8615793#comment-8615793

[D7] Gallery 3D
https://drupal.org/comment/8575661#comment-8575661
https://drupal.org/comment/8575877#comment-8575877

This page serves gobinathm's project application reviews and help to project application reviews. This is a part of mentoring to become a code review administrator eventually. Add any advice that you may have through comments.

VOD Infomaniak : https://drupal.org/node/2241281#comment-8704869
[D7] EditHub : https://drupal.org/comment/8564623#comment-8564623
[D7] commerce_unionpay : https://drupal.org/comment/8545515#comment-8545515



[D7] Amazon SendtoKindle Button Integration : https://drupal.org/comment/8705917#comment-8705917

This page serves mpdonadio's project application reviews and help to project application reviews. This is a part of mentoring to become a code review administrator eventually. Add any advice that you may have through comments.

This page serves izus's project application reviews and help to project application reviews. This is a part of mentoring to become a code review administrator eventually. Add any advice that you may have through comments.

<

ol>

This page serves ARUN AK's project application reviews and help to project application reviews. This is a part of mentoring to become a code review administrator eventually. Add any advice that you may have through comments.

Security Issues

[D7] Localist Calendar for Drupal
https://www.drupal.org/node/2784545#comment-11643883

[D7] Custom Sitename
https://www.drupal.org/node/2786217#comment-11643571

[D7]Bootstrap Banners Widget
https://www.drupal.org/node/2771627#comment-11636237

[D7] Multiple role login pages

As you might have noticed I have scaled back my efforts on the project applications issue queue a bit, meaning that I'm busy with other things and cannot review as many project applications as I did in the past. I won't stop reviewing applications completely, so don't worry: I'm not gone :-)

As a consequence the review bonus program will not work as good as it previously did and applicants will have to wait a couple of weeks before they get my attention.

This page serves xqus's project application reviews and help to project application reviews. This is a part of mentoring to become a code review administrator eventually. Add any advice that you may have through comments.

The queue's purpose is not sufficiently stated, and the complaints I've seen arise from that.

The first purpose is to evaluate the applicant in order to grant "git vetted user" status.

We do this mainly by evaluating a submitted module's code. Too often applicants and even sometimes reviewers confuse the module-review portion with the main purpose of the queue. A more perfect module is not actually our goal.

A common submission seems to be adding Addressfield support for a particular country. They tend to be very small modules, often failing the "Code Too Short" check recently removed.

The question is, do we accept these as modules or suggest a patch instead. I think Mac_Weber put it best in https://drupal.org/comment/7802523#comment-7802523 where he argues for a patch to the existing Addressfield module. I'm in favor of patches as well, but our response, whatever it is, should be consistently applied.

Related addressfield applications:

<

ul>

@klausi, many thanks for responding to previous threads relating to the issue of "Pareview Bonus - requirement for reviews".

For others reading this, I should say that Klausi has advised me to raise a new discussion here, rather than mentioning it in overlapping discussion threads.

The gist of which is that many people, including myself, feel that requiring new contributors to do a certain amount of reviews is a good way to get them involved and relieve some of the backlog. However, there is a level of frustration with the process, which I can partly summarize as follows:

<

ol>

See https://drupal.org/node/1587704 and https://drupal.org/node/1587704/revisions/view/2790779/6706319

This section was confusing and lead reviewers as well as applicants to believe that modules would have to exceed a certain length to be even considered in the project application process. This is not true, we just can't give the git vetted user role away on very short projects, but we will always promote them manually. Applicants can always come back to us when they have a new project for promotion.

This seems to affect sandboxes created pre-upgrade, that were promoted to full projects post-upgrade. This could affect all the projects we're promoting out of the application queue.

• The immediate issue is here: https://drupal.org/node/2132003 - please add any other modules where you see the problem.
• The meta issue is here: https://drupal.org/node/2132659.

I have scheduled a BoF for Drupalcon Prague about the project application review process: https://prague2013.drupal.org/bof/how-publish-project-drupal.org (Thursday 1pm)

I hope to see you there and please spread the word!

http://ventral.org/ --> http://pareview.sh/

The service has finally got the name it deserves ;-)

If you run into a d.o / g.d.o documentation pointing to the old one, please correct it.

thanks