-
Notifications
You must be signed in to change notification settings - Fork 401
ZStack build failed for missing org.zstack:log4j2 dependency #1266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
546a05b to
f295196
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You moved the dependency to the "premium" profile - that is not expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no org.zstack:log4j2 module under zstack and the maven can not find this dependency during building. So i guess the module is under premium version and move it there. Any suggestion about the placement of org.zstack:log4j2 dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@live4thee Could we just remove this log4j2 dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the code base and it turned out that your patch is correct. I will merge it. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged.
ZStack build failed for missing org.zstack:log4j2 dependency.
Solution: Move the org.zstack:log4j2 dependency under premium profile.