Skip to content

Avoid getting the "Syntax error" from json_decode #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

mnajafzadeh wants to merge 1 commit into zoonman:master

from mnajafzadeh:patch-1

Open

Avoid getting the "Syntax error" from json_decode #29

Changes from all commits

Commits

Show all changes

Select commit

Avoid getting the "Syntax error" from json_decode

mnajafzadeh Nov 7, 2018

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

11 changes: 7 additions & 4 deletions src/Client.php

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -308,10 +308,13 @@ public function getAccessToken($code = '')
		*/
		public static function responseToArray($response)
		{
	return \GuzzleHttp\json_decode(
	$response->getBody()->getContents(),
	true
	);
	if ($contents = $response->getBody()->getContents()) {
	return \GuzzleHttp\json_decode(
	$contents,
	true
	);
	}
	return array();
Copy link Contributor @iamsalnikov iamsalnikov Jan 30, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. I see in `composer.json` that we require PHP >= 5.6. So, I want to suggest change this line to `return []`. But this is not obligatory, just my small tip. zoonman reacted with thumbs up emoji
		}

		/**
Expand Down