-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
@Zebiano
Zebiano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the string problem, all seems to be fine. If possible, could you also update endAt and guildBattleType to be of type string as well?
- Add af-daily > requiredLevel - Deploy > checkConfig - Switch to campaignChapter and campaignStage
kevingrillet
commented
Oct 21, 2021
Should work, but need to be tested ;)
kevingrillet
commented
Oct 23, 2021
After merge with #133 will require to update the wiki examples 😉
Add: Info to terminal Update: Format files
Note to self:
- Update Wiki page
AFK Arena requirementswith correct values found here.
kevingrillet
commented
Jan 6, 2022
I'll work on it next week if my test account gets back to work.
But I think we already did 99% of the work.
I've been taking a look at this, and I think I want to make it a bit more different. I'd rather have a function dedicated to checking everything related to required levels/stages before executing the init function, rather than cluttering up the main "if doAction then doAction" section of the file with requirement checks.
(削除) I'm still unsure if we should exit the script if we found stuff the user has invalid requirements, or take other actions instead. (削除ここまで) I've decided to let the script take actions automatically. This means the script will warn the user "Yo, I can't do that!" and then proceed to either do something that it can do or skip it. I think this is the best approach, as else it would defeat the purpose of having a feature that checks for player levels, etc, as it would simply be annoying for everyone and no one would make use of it.
I'll take care of it this week hopefully!
Update: `requiredLevel` function WIP: Pushing changes to not lose them
Update: Default `endAt` entry is now `campaign` Update: `eventHoe=true` Add: `runOakSpeedy` variable for the script to know when to run `oakInn_Speedy`
Update: Timings Update: Function `requiredLevel()` doesn't differentiate between stage `0` and `1`, which means it's possible to set a VIP and Chapter level without setting a stage
Alright, the PR is basically done now: VIP, Chapter and Stage are now settable in the config, and it also fixes (hopefully) #118 and #103. It could be merged like this, yet it's fairly simple to implement the rest of the necessary changes to take lower-level Players into consideration, so I'm considering doing that. I guess my plan is to create some more issues and then either fix them on this PR or "per issue" in the future.
Fix #104 & #103