Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jul 19, 2020. It is now read-only.

6-8 Styling page, Move Nested components page#87

Open
rlasjunies wants to merge 6 commits into
yewstack:master from
rlasjunies:nested-components
Open

6-8 Styling page, Move Nested components page #87
rlasjunies wants to merge 6 commits into
yewstack:master from
rlasjunies:nested-components

Conversation

@rlasjunies

@rlasjunies rlasjunies commented May 8, 2020

Copy link
Copy Markdown

Remove of the CSS.md and add the Styling page
Move from html! the component page, rename it NestedComponents

Update summary

@rlasjunies rlasjunies changed the title (削除) 6-8 Stylin page, Move Nested components (削除ここまで) (追記) 6-8 Styling page, Move Nested components (追記ここまで) May 8, 2020
@rlasjunies rlasjunies changed the title (削除) 6-8 Styling page, Move Nested components (削除ここまで) (追記) 6-8 Styling page, Move Nested components page (追記ここまで) May 8, 2020
Comment thread src/concepts/components/styling.md Outdated
Comment thread src/concepts/components/styling.md Outdated
Comment thread src/SUMMARY.md Outdated
* [Nested component](concepts/components/nestedcomponents.md)
* [Refs](concepts/components/refs.md)
* [Styling](concepts/components/styling.md)
* [Life cycle](concepts/components/lifecycle.md)

@teymour-aldridge teymour-aldridge May 9, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stylistically, I think it's better for "life cycle" to be "lifecycle."

@rlasjunies rlasjunies May 9, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ask myself about it and google it. Found more about "Life Cycle"
Anyway ... we are 2 having the same feeling => I change to 1 word

Comment thread src/concepts/components/nestedcomponents.md Outdated
Comment thread src/concepts/components/styling.md Outdated

## Yew component does not support yet class attribute

So far Yew component does not support natively the `class` attribute. You can add the class attribute to your component:

@teymour-aldridge teymour-aldridge May 9, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gramatically this should read more along the lines of "At the moment Yew's components don't natively support the class attribute."

@rlasjunies rlasjunies May 9, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this limitation is now resolved with the 0.16 release with #1187
=> I remove the chapter

Comment thread src/concepts/components/styling.md Outdated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@teymour-aldridge teymour-aldridge teymour-aldridge left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /