-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Update package.json dependencies to the latest versions, migrat... #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jzolnowski
jzolnowski
commented
Feb 10, 2023
- Update package,json dependencies to the latest version
- Migrate Gulp to v4
- Update README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions.
Otherwise lgtm 👍
@gkalpak PR ready for final review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :shipit:
@Splaktar PR ready for final review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see the package-lock.json file in GitHub but please make sure that is was generated with npm v6.
generate package-lock.json with npm v6
package-lock.json generated with npm v6
@jzolnowski please rebase and resolve conflicts.
Branch is up-to-date with master
@jzolnowski please rebase and resolve conflicts.
...e gulp to v4, udpate README
ab09fd2 to
b9dc89e
Compare
@jzolnowski please rebase and resolve conflicts.
Branch rebased with master